Fossil

Check-in [912ca195]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Remove side effect produced when calling with no flags. This permits removal of work around in sync.c.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | url-password-fixes
Files: files | file ages | folders
SHA1:912ca195104e7dab99ac0fd8d7b5ebdcb271ce33
User & Date: andybradford 2013-11-08 07:50:24
Context
2013-11-09
02:38
Prefer use of fossil_strcmp that handles NULL better. check-in: e97665e0 user: andybradford tags: url-password-fixes
2013-11-08
07:50
Remove side effect produced when calling with no flags. This permits removal of work around in sync.c. check-in: 912ca195 user: andybradford tags: url-password-fixes
06:01
Clean up handling of passwords for SSH. Further separate prompting for password from saving of password. check-in: ad34c07c user: andybradford tags: url-password-fixes
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/sync.c.

119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
  }
  url_parse(zUrl, urlFlags);
  url_remember();
  if( g.urlProtocol==0 ){
    if( urlOptional ) fossil_exit(0);
    usage("URL");
  }
  urlFlags = g.urlFlags;
  user_select();
  g.urlFlags = urlFlags;
  if( g.argc==2 ){
    if( ((*pSyncFlags) & (SYNC_PUSH|SYNC_PULL))==(SYNC_PUSH|SYNC_PULL) ){
      fossil_print("Sync with %s\n", g.urlCanonical);
    }else if( (*pSyncFlags) & SYNC_PUSH ){
      fossil_print("Push to %s\n", g.urlCanonical);
    }else if( (*pSyncFlags) & SYNC_PULL ){
      fossil_print("Pull from %s\n", g.urlCanonical);







<

<







119
120
121
122
123
124
125

126

127
128
129
130
131
132
133
  }
  url_parse(zUrl, urlFlags);
  url_remember();
  if( g.urlProtocol==0 ){
    if( urlOptional ) fossil_exit(0);
    usage("URL");
  }

  user_select();

  if( g.argc==2 ){
    if( ((*pSyncFlags) & (SYNC_PUSH|SYNC_PULL))==(SYNC_PUSH|SYNC_PULL) ){
      fossil_print("Sync with %s\n", g.urlCanonical);
    }else if( (*pSyncFlags) & SYNC_PUSH ){
      fossil_print("Push to %s\n", g.urlCanonical);
    }else if( (*pSyncFlags) & SYNC_PULL ){
      fossil_print("Pull from %s\n", g.urlCanonical);

Changes to src/url.c.

209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
    }else{
      free(zFile);
      fossil_fatal("unknown repository: %s", zUrl);
    }
  }else{
    fossil_fatal("unknown repository: %s", zUrl);
  }
  g.urlFlags = urlFlags;
  if( g.urlIsFile ){
    Blob cfile;
    dehttpize(zFile);  
    file_canonical_name(zFile, &cfile, 0);
    free(zFile);
    g.urlProtocol = "file";
    g.urlPath = "";







|







209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
    }else{
      free(zFile);
      fossil_fatal("unknown repository: %s", zUrl);
    }
  }else{
    fossil_fatal("unknown repository: %s", zUrl);
  }
  if( urlFlags ) g.urlFlags = urlFlags;
  if( g.urlIsFile ){
    Blob cfile;
    dehttpize(zFile);  
    file_canonical_name(zFile, &cfile, 0);
    free(zFile);
    g.urlProtocol = "file";
    g.urlPath = "";