Fossil

Check-in [2e9ac33a]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Change style_submenu_entry() to allow zero and negative iSize. Zero iSize means display size and length limit are not specified, and negative iSize means no length limit is specified but the display size is set to the absolute value of iSize.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | andygoth-timeline-ms
Files: files | file ages | folders
SHA1:2e9ac33a9ad54a8abee2d1cc86967d07c43ca9f1
User & Date: andygoth 2016-11-04 15:52:22
References
2016-11-05
03:14
Cherrypick [2e9ac33a9a] check-in: e32803bb user: andygoth tags: trunk
Context
2016-11-04
16:21
Add timeline web UI to set tag filter and match style. Still not 100%. (1) Now that more than one text entry is on the page, pressing enter does not trigger a submit [Firefox ESR 10.0.12], (2) electing "Related" causes Tag Filter to blank, (3) entering a tag filter while "Related" is selected causes "Related" to be deselected, (4) possibly too much clutter, and (5) definitely too much clutter if combined with any future expansions. (1) is due to the lack of a submit button. (2) and (3) are a bad interaction between the t=/r= dichotomy and the design of style_submenu_entry(). (4) maybe could be addressed by changing "Related"/"Branch Only" and "Without Files"/"With Files" to checkbuttons, but style_submenu_checkbox() was never actually implemented. (Probably also want "Unhide" to be a checkbox.) For (5) I have in mind letting the admin define a project-specific list of preset filters. check-in: d4a6d3c1 user: andygoth tags: andygoth-timeline-ms
15:52
Change style_submenu_entry() to allow zero and negative iSize. Zero iSize means display size and length limit are not specified, and negative iSize means no length limit is specified but the display size is set to the absolute value of iSize. check-in: 2e9ac33a user: andygoth tags: andygoth-timeline-ms
15:48
Move GLOB before LIKE in list of possible match styles check-in: fc25a127 user: andygoth tags: andygoth-timeline-ms
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/style.c.

534
535
536
537
538
539
540
541
542
543

544




545




546
547
548
549
550
551
552
553
554
          zDisabled = "";
          cgi_tag_query_parameter(zQPN);
        }
        switch( aSubmenuCtrl[i].eType ){
          case FF_ENTRY: {
            cgi_printf(
               "<span class='submenuctrl'>"
               "&nbsp;%h<input type='text' name='%s' size='%d' maxlength='%d'"
               " value='%h'%s></span>\n",
               aSubmenuCtrl[i].zLabel,

               zQPN,




               aSubmenuCtrl[i].iSize, aSubmenuCtrl[i].iSize,




               PD(zQPN,""),
               zDisabled
            );
            break;
          }
          case FF_MULTI: {
            int j;
            const char *zVal = P(zQPN);
            if( aSubmenuCtrl[i].zLabel ){







|
<
|
>
|
>
>
>
>
|
>
>
>
>
|
<







534
535
536
537
538
539
540
541

542
543
544
545
546
547
548
549
550
551
552
553
554

555
556
557
558
559
560
561
          zDisabled = "";
          cgi_tag_query_parameter(zQPN);
        }
        switch( aSubmenuCtrl[i].eType ){
          case FF_ENTRY: {
            cgi_printf(
               "<span class='submenuctrl'>"
               "&nbsp;%h<input type='text' name='%s'",

               aSubmenuCtrl[i].zLabel, zQPN
            );
            if( aSubmenuCtrl[i].iSize<0 ){
               cgi_printf(" size='%d'", -aSubmenuCtrl[i].iSize);
            }else if( aSubmenuCtrl[i].iSize>0 ){
               cgi_printf(
                  " size='%d' maxlength='%d'",
                  aSubmenuCtrl[i].iSize, aSubmenuCtrl[i].iSize
               );
            }
            cgi_printf(
               " value='%h'%s></span>\n",
               PD(zQPN,""), zDisabled

            );
            break;
          }
          case FF_MULTI: {
            int j;
            const char *zVal = P(zQPN);
            if( aSubmenuCtrl[i].zLabel ){