Fossil

Check-in [9036122d]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Use <label> to connect setup checkboxes with their label text so either the checkbox or the label can be clicked on, also makes the checkbox highlight when the mouse hovers on the label
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:9036122dcb7120d43ff4f7efb81c88e316efa0c8
User & Date: andygoth 2016-11-05 03:24:44
Context
2016-11-05
04:02
Draw dotted box around entire row of checkout version, not just the check-in comment and descriptive text. In my experience, it's too hard to see the dotted box against a colored background when the checkout version is on a branch. This whole-row behavior matches the version marking option provided by the timeline "m" query string. I considered also increasing the line thickness from 1px to 2px, but I found it to be too distracting. Instead, I added a very faint shadow similar to, but much lighter than, the one used by the "m" version marker. check-in: e5b53f15 user: andygoth tags: trunk
03:34
Merge trunk. Some issues identified by [d4a6d3c1ec] are now improved. (1) is fixed, though clicking/tabbing outside the entry field also triggers a submit which may prove annoying. (2) and (3) are still broken. (4) is better because "With/Without Files" is now a checkbox simply labeled "Files". (5) is closer to being feasible, perhaps if "Tag Filter:" is changed to "Filter:". check-in: 74fe9587 user: andygoth tags: andygoth-timeline-ms
03:24
Use <label> to connect setup checkboxes with their label text so either the checkbox or the label can be clicked on, also makes the checkbox highlight when the mouse hovers on the label check-in: 9036122d user: andygoth tags: trunk
03:19
Add explicit call to form submit() when changing a text entry so style_submenu_entry() can be used multiple times per page check-in: 2929d5fc user: andygoth tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/setup.c.

938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
      login_verify_csrf_secret();
      db_set(zVar, iQ ? "1" : "0", 0);
      admin_log("Set option [%q] to [%q].",
                zVar, iQ ? "on" : "off");
      iVal = iQ;
    }
  }
  @ <input type="checkbox" name="%s(zQParm)"
  if( iVal ){
    @ checked="checked"
  }
  if( disabled ){
    @ disabled="disabled"
  }
  @ /> <b>%s(zLabel)</b>
}

/*
** Generate an entry box for an attribute.
*/
void entry_attribute(
  const char *zLabel,   /* The text label on the entry box */







|






|







938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
      login_verify_csrf_secret();
      db_set(zVar, iQ ? "1" : "0", 0);
      admin_log("Set option [%q] to [%q].",
                zVar, iQ ? "on" : "off");
      iVal = iQ;
    }
  }
  @ <label><input type="checkbox" name="%s(zQParm)"
  if( iVal ){
    @ checked="checked"
  }
  if( disabled ){
    @ disabled="disabled"
  }
  @ /> <b>%s(zLabel)</b></label>
}

/*
** Generate an entry box for an attribute.
*/
void entry_attribute(
  const char *zLabel,   /* The text label on the entry box */