Fossil

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

110 check-ins by user wyoung

2018-09-21
01:52
Replaced the "hasOwnProperty" test for CSS transition support in the animated hamburger menu JS code with a better test that not only works on old IE but also on some truly ancient versions of SeaMonkey, Firefox, Chrome, etc. Leaf check-in: ee074372 user: wyoung tags: trunk
2018-09-20
11:21
Fixed the panel.style.hasOwnProperty() test in the default skin's js.txt so that it will work on IE8 and below. See code comment for rationale. check-in: e54095f9 user: wyoung tags: trunk
2018-09-17
09:47
Wiki markup fixes in the recent edits to the www/forum.wiki doc check-in: 07943152 user: wyoung tags: trunk
09:40
Removed a paragraph stranded by the email docs reorg several checkins ago. check-in: ba35b5ff user: wyoung tags: trunk
09:33
Fixed a typo check-in: 692aceed user: wyoung tags: trunk
08:20
Added colored shading, more padding, and a thick left border to elements in the default skin. This is based on some custom styling that Florian Balmer has been doing for quoted text on the forum lately, but the styling is rather different. It affects all such elements, not just those in forum posts, since I couldn't see a good reason to restrict it: it should be equally valuable in wiki and embedded doc articles as well. check-in: 2190f86c user: wyoung tags: trunk
02:58
Updated the documentation permuted index to include a grammar fix checked in with the previous checkin. check-in: d8d979fe user: wyoung tags: trunk
02:57
Reworked the documentation for email alerts to put all the information in a single document: a) Moved the "quick email setup" material from the forums.wiki document into `alerts.md`; b) linked to that moved material from its original location; c) greatly expanded the material previously present in the `alerts.md` document; c) merged the `emaildesign.md` document into `alerts.md`, so we don't have to link out to two separate documents which previously partially repeated each other. This pass also fixed a number of grammar errors and broken links. check-in: 2ef70be2 user: wyoung tags: trunk
2018-09-16
21:14
Replaced the WIP and indefinite future paragraphs in www/alerts.md with definite statements now that we're approaching release. check-in: 05b40829 user: wyoung tags: trunk
2018-09-15
17:37
Added www/forum.wiki to the documentation index. check-in: 7bd7b2c6 user: wyoung tags: trunk
2018-09-12
13:39
Removed the anti-robot defense stand-down call from the default skin's new footer JS: that's handled server-side now with /sitemap?popup=1. check-in: 7d5ff435 user: wyoung tags: trunk
13:20
Added copyright and license comment to the top of the new skins/default/js.txt file. check-in: 972ae10b user: wyoung tags: trunk
12:33
Avoided a divide by 1000 by changing a value formerly specified in floating point seconds to be specified in milliseconds, so we don't need the arithmetic. check-in: 1d5eea66 user: wyoung tags: trunk
12:32
Moved a single-use variable interpolation inline with its use point. Also improved some comments. check-in: 56db6170 user: wyoung tags: trunk
2018-09-10
13:41
Added a guard on the use of CSS transitions so it falls back to a non-animated menu pull down if they appear not to be available on the current browser. Also added a check for the existence of the hamburger menu item in case the skin admin diked it out, and did a few other minor tweaks to the footer JS code. check-in: 5d9a3454 user: wyoung tags: js-hamburger-menu
10:01
Timing tweaks: made "hide borders" hack occur about the same time as the CSS transition finishes, and increased the menu show delay still further to make it work for Firefox. check-in: 7bb68023 user: wyoung tags: js-hamburger-menu
09:30
Changed hamburger menu drop-down menu from 33% of the screen width to 90%: it works better on small screens, and it allows the sitemap to go multi-column on wider screens. Also added some right-side padding to balance the padding added for on the left. check-in: e76a243d user: wyoung tags: js-hamburger-menu
09:27
Removed the wrapping and moved the multicolumn styling applied to it down to the , since it is already a block level element, so we don't need a div wrapper on it. And then there's the real reason, which is that we want the multicolumn styling to work on the drop-down hamburger menu version as well. check-in: 0d391a1b user: wyoung tags: js-hamburger-menu
09:02
Increased the transition delay to make the initial drop-down animation happen in Firefox 62. check-in: 8918a8a8 user: wyoung tags: js-hamburger-menu
08:48
Using CSS transitions to mimic jQuery's slideUp/Down() transitions. This probably restricts browser compatibility still further above the XHR issue noted in the earlier checkin on this branch. According to MDN, we're probably restricted to IE 10+ with this, and maybe not even that due to not using vendor-specific extensions for the transitional browser versions. check-in: 90bd6675 user: wyoung tags: js-hamburger-menu
07:17
Converted JS hamburger button menu code to use standard JS only, no jQuery.    Temporarily lost the animation with this change: I'm checking this in separately to make the difference between this and the jQuery version clearer.    Not sure how portable it is yet; I wouldn't be surprised if it broke on old IE, since we're using xhr.onload instead of the horrid mess that is xhr.onreadystatechange. check-in: 113ba3d9 user: wyoung tags: js-hamburger-menu
2018-09-09
17:42
Merged in trunk improvements check-in: 96b1a9ca user: wyoung tags: js-hamburger-menu
17:41
Reverted [59c7ca0509]: drh says we can't use jQuery. Also, there was a syntax error that sent all hyperlinks to the honeypot in some conditions. check-in: 5a62b395 user: wyoung tags: js-hamburger-menu
2018-09-06
03:56
The hyperlinks in the hamburger menu drop-down still had the anti-robot defense activated. Defeated it. check-in: 571df2e8 user: wyoung tags: js-hamburger-menu
03:56
Converted src/href.js to jQuery as a demonstration: the code's nearly half the size, and it's clearer as a result. check-in: 59c7ca05 user: wyoung tags: js-hamburger-menu
03:06
Typo fix; patch by jungleboogie in forum post ID 775e4c0771. check-in: c8ef388b user: wyoung tags: trunk
2018-09-05
23:45
Fixed a bug in the onclick handler for the new hamburger button which allowed the browser to follow our empty 'a href="#"' link. For some reason, Chrome only did this sometimes, not always, which lead to me thinking it was some kind of race condition. check-in: e806e5c4 user: wyoung tags: js-hamburger-menu
23:08
Ajaxy animated drop-down menu on clicking a new hamburger button in the default skin, as requested by drh on the forum: https://fossil-scm.org/forum/forumpost/40a18bd742    Initial version uses jQuery loaded from Google Hosted APIs for ease of development. check-in: d7c43c5a user: wyoung tags: js-hamburger-menu
2018-09-04
12:10
Added more info on quoting rules in Tcl/TH1 to the th1.md doc check-in: 30e9ccd5 user: wyoung tags: trunk
11:59
Fixed some grammar and spelling in the th1.md doc. check-in: 40787f50 user: wyoung tags: trunk
2018-09-03
07:40
Calling db_end_transaction() from the early-exit code paths of setup_skin_admin() to avoid "Transaction started at ./src/skins.c:466 never commits" complaints with some types of Admin -> Skins edits. check-in: 1c0b78b4 user: wyoung tags: trunk
07:06
Merged wrap-run_in_checkout branch down to trunk. check-in: 49e86fe0 user: wyoung tags: trunk
06:27
The test harness now skips all tests done in the Fossil source repo checkout directory while there are uncommitted changes because that will affect the behavior of fossil status, fossil diff, etc., which in turn tends to create false positives in test harness code that checks for changes in fossil command output. Closed-Leaf check-in: 78ec6838 user: wyoung tags: wrap-run_in_checkout
06:22
Partially reverted one of the run_in_checkout replacements in test/th1.test: it was inside a foreach loop, which means the test for whether we're inside the Fossil repo checkout was being done 26 times. This is not only inefficient, it spammed the output with "Skipping test blabla..." lines. Now doing a manual check outside the loop and skipping the in-repo tests silently inside the loop. check-in: 3cb1b4f0 user: wyoung tags: wrap-run_in_checkout
06:19
Fixed a Tcl syntax error checked in with [33efa2fa]. (Yay dynamic languages that run the code even if it's syntactically invalid. P'tui!) check-in: 4315d464 user: wyoung tags: wrap-run_in_checkout
06:15
The new test_block_in_checkout proc in tester.tcl was not setting the CODE and RESULT global variables when it skipped a test, so there was a chance that a test would end up checking the prior values and throw a false positive. check-in: 2aaee484 user: wyoung tags: wrap-run_in_checkout
06:13
Fixed a Tcl logic error committed with [33efa2fa]. check-in: 02430597 user: wyoung tags: wrap-run_in_checkout
02:57
Extracted the logic that was in tester.tcl's new outside_fossil_repo proc to the global level which just saves the result to a global variable so the logic doesn't have to be re-run for each test that relies on it. The result doesn't change from one call to the next, as you'd hope for a proc without parameters. check-in: 1a4e87dc user: wyoung tags: wrap-run_in_checkout
00:40
Replaced most of the direct calls to run_in_checkout from within the test suite with one of two wrapper functions that skip those tests when you run "make test" outside a Fossil repository checkout directory, such as from a directory containing an unpacked source release tarball. (The two remaining direct calls to that proc from test/*.test are preceded by a check that skips the whole file they're in, since that whole file does nothing else.) This is being checked in on a branch because it is not yet thoroughly tested, yet I need the checkpoint. check-in: 33efa2fa user: wyoung tags: wrap-run_in_checkout
00:24
The -quiet flag passed by default to tester.tcl can now be overridden by passing TESTFLAGS to make. Before, there was no way to set -verbose this way because "-quiet -verbose" means the same thing as "-quiet". check-in: 401a4c3d user: wyoung tags: trunk
2018-09-02
23:05
Cached the result of "$tcl_platform(platform) eq "windows"" in test/tester.tcl and replaced all of the repetitions of this expression with a test of the variable. check-in: 2e4143aa user: wyoung tags: trunk
21:51
Removed a debug message accidentally checked in. check-in: 8eadf4c4 user: wyoung tags: trunk
21:47
Merged tclsh-macos down to trunk. check-in: ee2ffe35 user: wyoung tags: trunk
21:46
Fixed an incorrect Tcl string comparison checked in with [e449cb09]. Closed-Leaf check-in: c94617b5 user: wyoung tags: tclsh-macos
21:00
Explained "Why can't we use Jim Tcl for the test suite?" in the auto.def comment above the check for a suitable tclsh version. Basically, I tried it and then documented a few of the resulting failures. check-in: 91eaef61 user: wyoung tags: tclsh-macos
20:33
After autosetup checks for the existence of tclsh in the PATH, it now checks whether it's at least version 8.6, because macOS is still shipping 8.5, despite it being nearly 6 years old. If we find an old tclsh, try to find the Homebrew tcl-tk package, and use that version instead. This is not a macOS or Homebrew specific change in principle: we can extend this logic for other systems to find their best Tcl/Tk version, as needed.    On systems where autosetup is used, this only affects "make test". There are other uses of tclsh in this tree which may also benefit from our PATH discoveries, but this checkin doesn't update those.    This checkin also doesn't try to address similar problems on other platforms, such as the "TCLSH = tclsh" line in Makefile.mingw. check-in: e449cb09 user: wyoung tags: tclsh-macos
2018-09-01
20:49
Noted the responsive design changes to the default skin in the change log. Expanded on the forum and alerts feature items. Changed all the past-tense verbs to present tense to match the rest of the items and the prevailing style in past change log entries. check-in: 6f87b4af user: wyoung tags: trunk
20:19
Added "overflow-y: hidden;" to the CSS for the default skin to prevent some browsers (Chrome, Firefox, and Safari on macOS, at least) from adding a vertical scroll bar to the navbar. This was only necesasry on this skin because of the recently-added "overflow-x: auto" style, which tells the browser to clip or horizontally-scroll the navbar if the screen width isn't sufficient to show the whole thing; previously in this skin, and currently in all other skins, this condition causes the navbar to wrap to the next line, which looks particularly bad on the default skin. I believe this then made these browsers calculate some extra space for a possible horizontal scroll bar, which then ran the layout engine out of space, so it included the vertical bar just in case. This may be macOS specific, due to the scroll bar hiding behavior introduced several OS release back. check-in: e8783b9a user: wyoung tags: trunk
2018-08-29
03:31
Fixed some Markdown-isms just checked into www/forum.wiki. check-in: 34a3bc12 user: wyoung tags: trunk
03:25
Assorted improvements to the "Skin Setup" section of forum.wiki. check-in: 04d4bde1 user: wyoung tags: trunk
03:13
Clarity fixes to the Email Alerts capability paragraph of forum.wiki check-in: d6e5754d user: wyoung tags: trunk
2018-08-26
03:35
Applied the new CSP nonce to the <script> tags in the header for the Enhanced Original, Eagle, and Xekri skins, else the clock in the upper right breaks and Chrome gives an error about the CSP violation. Closed-Leaf check-in: b9d86ed2 user: wyoung tags: csp-nonce
2018-08-25
20:41
Coloring the hyperlinks to the newest forum posts from /forum with a dimmer and less saturated version of the normal hyperlink color in the default skin, to test the new div.forumPosts selector. Other skins to be updated later if this is approved. check-in: 86ff84da user: wyoung tags: trunk
17:24
Merged forum-skin-links branch to trunk. check-in: 91c2b1b6 user: wyoung tags: trunk
16:06
Added new CSS class forumPosts to the containing the list of posts on the /forum page so that skins can target elements of this list differently than others. One immediate use for this is styling read threads differently via a:visited styling. Currently, only one of the stock skins ships with an unconditional a:visited change, so that all links show in the same color regardless of their state. That's fine in most areas of the UI, but in the forum, a skin developer may want something special, so we need a way to mark them differently. This was already using the broadly-used "fileage" style, but we don't want changes to a:visited and such to affect all other users of fileage, so we need a unique style to this page. check-in: 77782490 user: wyoung tags: trunk
2018-08-17
01:27
Allow + signs in email addresses. Added a comment to link to a source giving the true limit on legal characters in email addresses, which are currently far less restrictive than our newly-expanded limits. check-in: 1bfd7903 user: wyoung tags: trunk
2018-08-16
07:21
Improved locality of a variable. No functional change. check-in: 09103fd2 user: wyoung tags: trunk
07:06
Posts are now hidden on the /forum page if they're marked as private (i.e. needing moderator attention) and they were posted by another user, except when the user is a moderator.    (Closed because a different method was implemented on trunk.) Closed-Leaf check-in: 779eaaae user: wyoung tags: hide-post-if-needmod
06:36
Replaced a declare-and-init line pair with a single define-with-value line. No functional change. check-in: 8f47c3f6 user: wyoung tags: trunk
2018-08-14
05:59
Changed all of the "sendmail -t" commands to "sendmail -ti" to make it ignore lines containing only a dot; we use EOF to signal "end of message," so we don't need the second signal. This is separate from the smtp.c fix in [51740ce45f]: that's only used when Fossil speaks directly to an SMTP server, where a leading dot is treated somewhat differently than the lone dot rule for sendmail(1)'s stdin.    This problem with leading dots was diagnosed by gumblex, /forumpost/4290f75ba1. check-in: 8c0ec30b user: wyoung tags: trunk
04:39
URL fix check-in: 6787aac9 user: wyoung tags: trunk
03:55
The blob-to-SMTP encoding logic was not strictly following RFC 5321 in that it was only dealing with the lone dot on the line case, doubling it to prevent the SMTP server from interpreting that as end-of-message. It missed the case where, if anything follows the dot, SMTP drops the leading dot, so you must also double the leading dot in that case. Basically, you always double a leading dot, regardless of line length.    This only affects Fossil's direct-to-SMTP email sending case, not those that send via a piped command or via DB. That is dealt with later in [8c0ec30bc3]. check-in: 51740ce4 user: wyoung tags: trunk
2018-08-13
03:51
Covered capability 7 in the forum.wiki document, and made several improvements to the "Using the Moderation Feature" section. check-in: 31631b75 user: wyoung tags: trunk
03:23
Assorted minor improvements to the www/alerts.md document. The major one is re-emphasizing the need to give capability 7 to some user or user category. Ask me how I came to think this necessary. :) check-in: 3e75a683 user: wyoung tags: trunk
01:11
Typo fix check-in: c3d9c8e0 user: wyoung tags: trunk
00:59
More forum.wiki tweaks check-in: 26424763 user: wyoung tags: trunk
00:31
Assorted improvements to the forum.wiki document, mainly to the new moderation material. check-in: c1be5508 user: wyoung tags: trunk
2018-08-12
23:24
Added the "How Moderation Works" section to www/forum.wiki, and improved the newly-renamed "Using the Moderation Feature" section as a result. check-in: 812dd52c user: wyoung tags: trunk
22:27
Added "id"s to every header tag in the forum.wiki document, so you can create links to sub-sections. check-in: 03c298dc user: wyoung tags: trunk
21:40
Fixed a few references to MIME type "text/x-fossil" in the fileformat document. It's "text/x-fossil-wiki" everywhere else. check-in: e00cdbe7 user: wyoung tags: trunk
21:35
Add /forum link to sitemap if user has RdForum capability check-in: 5ad7222f user: wyoung tags: trunk
06:11
URL fix in forum.wiki check-in: 542c5576 user: wyoung tags: trunk
03:21
Added the "Moderation" section to www/forum.wiki check-in: e06e7f84 user: wyoung tags: trunk
03:00
Assorted tweaks and improvements to the new email alerts material in www/forum.wiki. check-in: 4326f76f user: wyoung tags: trunk
02:47
Added the "Email Notification" section to the forum.wiki document. check-in: 6b275203 user: wyoung tags: trunk
2018-08-11
21:04
Added forumSel adjustment advice to forum.wiki. check-in: 0194fb67 user: wyoung tags: trunk
20:49
The periodic "updateClock()" call made in the header for several of the built-in skins (Eagle, Enhanced1, and Xekri) violates the new stricter CSP, since it requires a JS eval. We don't need an eval here: we can pass the function's name literally to window.setTimeout instead, which treats it as a Function object, which doesn't need to be eval'd. check-in: eac15b4c user: wyoung tags: trunk
19:43
Added the "Enable Forum Search" section to www/forum.wiki check-in: cc5d2e1f user: wyoung tags: trunk
19:28
Zeroed a pointer in its declaration to squish a warning from GCC 4.8.4 on Ubuntu 14.04 about use of a potentially uninitted pointer. I don't think it's actually possible for the current code to use the pointer in the window between its declaration and first use, but I think we can afford the extra machine instruction this will cost us. (I assume newer GCCs are smart enough to analyze this situation correctly, which is why the warning hasn't been squished earlier.) check-in: 892781cb user: wyoung tags: trunk
16:59
Fix to checkin [8c91be8b], which was intended to allow the user to log in with the email found in the contact info field of the user table. That checkin is fine as far as it goes, but it only works if the caller doesn't subsequently try to use the passed user name for anything else, since it isn't actually a user name. This checkin causes the low-level login checking function to re-point the user name pointer at the actual login name discovered while scanning for matching email addresses. check-in: 33522ff4 user: wyoung tags: login-with-email
2018-08-09
06:59
Minor improvements to forum.wiki check-in: 635d2f63 user: wyoung tags: trunk
06:17
Tightned up the login-groups sub-section of the SSO section in forum.wiki. check-in: 60c586d7 user: wyoung tags: trunk
06:13
Tightened up the MTA point in www/forum.wiki, and added a bit about digest delivery. check-in: b51d6212 user: wyoung tags: trunk
06:04
More feature rah-rah in www/forum.wiki, plus better formatting. check-in: cce5da16 user: wyoung tags: trunk
04:34
Clarity pass on the forum capability names in www/forum.wiki to match nomenclature on the Admin -> Users page. check-in: 2490bfba user: wyoung tags: trunk
03:35
Added point about multiple copies of each matching post in web search results to the forum.wiki doc. check-in: 89ab99e3 user: wyoung tags: trunk
2018-08-08
19:43
More SSO discussion improvements in forum.wiki check-in: bc303c0e user: wyoung tags: trunk
19:30
More tweaks to the forum.wiki doc check-in: 5d75504a user: wyoung tags: trunk
19:25
Small tweak to the advice for "reader" category capability for forums check-in: ea67aade user: wyoung tags: trunk
19:22
Added the "Skin Setup" section to the new forum.wiki document check-in: 3ec8f0a9 user: wyoung tags: trunk
19:09
Expanded the SSO discussion in the new forum.wiki document check-in: dd0a2dd3 user: wyoung tags: trunk
18:58
Fixed some incorrect uses of Markdown backticks in a document declared as wiki format. check-in: 76ca1f82 user: wyoung tags: trunk
18:55
Link fix in previous check-in: be74f259 user: wyoung tags: trunk
18:52
Several improvements to the new forum.wiki document check-in: f85bc326 user: wyoung tags: trunk
18:32
Typo fix check-in: 15b20343 user: wyoung tags: trunk
18:29
Fixed some Markdown formatting problems in www/emaildesign.md. Made a few minor grammar tweaks while in there. check-in: 30716e3c user: wyoung tags: trunk
17:21
Added initial version of www/forum.wiki document and a link to it from the front page. check-in: 4ed14b1f user: wyoung tags: trunk
13:19
Added Forum navbar before Tickets in all skins that had such a link, pointing to /forum if the user is anonymous and has capability 2 or 3, or is logged in and has any capabilities in 2-6 inclusive. Closed-Leaf check-in: 4344f806 user: wyoung tags: forum-skin-links
2018-06-04
12:40
Grammar tweak in the Fossil vs. Git document. check-in: ce4fb80e user: wyoung tags: trunk
12:39
Fixed an h2 -> h3 header level in the Fossil vs. Git document. check-in: 3b02193a user: wyoung tags: trunk
2017-12-13
21:37
Grammar fix check-in: ec059849 user: wyoung tags: trunk
2017-10-12
13:37
Rewrote the autoreconfigure explanation comment. It was confusing and contained errors. check-in: 50844e5c user: wyoung tags: trunk
2017-10-11
19:56
Removed the GNU make conditional around the new autoreconfigure dependency rule in the top-level Makefile.in. Apparently we have users using some other make, perhaps BSD make. Since the conditional only prevents autoreconfigure in the "make clean" case, where it is a minor annoyance, it's not important to work out how to retain this in a non-GNU make world. check-in: 454e1193 user: wyoung tags: trunk
01:30
Merged in an upstream improvement from Autosetup addressing GH issue in a different output file. That in turn requires an adjustment to our new autoreconfigure feature to avoid a make(1) loop. Closed-Leaf check-in: 1d549aa8 user: wyoung tags: wy-autoreconfig
01:23
Small path fix to the new autoreconfigure Makefile rule. check-in: b923d800 user: wyoung tags: wy-autoreconfig
01:16
Automatically re-configuring (same as "make reconfig") when Makefile.in, src/main.mk, or one of the autosetup files changes. This should avoid the need to recommend to people "re-run configure" whenever they call "fossil update" on this tree. check-in: c649ba27 user: wyoung tags: wy-autoreconfig
01:13
Added "reconfig" target to the top-level Makefile, which uses an autosetup feature to re-run configure with the same options you gave manually. check-in: fd33b6a4 user: wyoung tags: wy-autoreconfig
2017-09-08
04:05
Moved the check for iconv(3) in -liconv up within auto.def. If it happens after the checks for OpenSSL on certain macOS configurations, autosetup can be fooled into believing it doesn't need -liconv on that platform. This checkin splits up the group of cc-check-functions calls, so the moved call is now documented as to why its segregated. check-in: e6f64f5e user: wyoung tags: trunk
2017-05-01
13:57
Assorted tweaks to new Platform Quirks section of www/globs.md after re-reading it. check-in: a53d3b7d user: wyoung tags: glob-docs
13:34
Replaced the Platform Quirks section of the www/globs.md document with a modified version of what I (Warren Young) posted to the mailing list, the differences answering Ross Berteig critiques of the original version. check-in: 0a51f1bf user: wyoung tags: glob-docs