Fossil

Check-in [35939930]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Prevent incorrect attachment links from appearing on the timeline. Reported via the mailing list.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:359399307eec47efd02a7086e66111ca8d6ddb63
User & Date: mistachkin 2013-10-27 01:18:16
Context
2013-10-27
04:48
Modify TH1/Tcl integration macros to avoid using a generic variable name. check-in: 63a9998c user: mistachkin tags: trunk
01:18
Prevent incorrect attachment links from appearing on the timeline. Reported via the mailing list. check-in: 35939930 user: mistachkin tags: trunk
01:17
Fix harmless compiler warning. check-in: 9147aa2c user: mistachkin tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/manifest.c.

  1897   1897       );
  1898   1898       if( strlen(p->zAttachTarget)!=UUID_SIZE
  1899   1899        || !validate16(p->zAttachTarget, UUID_SIZE) 
  1900   1900       ){
  1901   1901         char *zComment;
  1902   1902         if( p->zAttachSrc && p->zAttachSrc[0] ){
  1903   1903           zComment = mprintf(
  1904         -             "Add attachment [%R/artifact/%S|%h] to wiki page [%h]",
         1904  +             "Add attachment [/artifact/%S|%h] to wiki page [%h]",
  1905   1905                p->zAttachSrc, p->zAttachName, p->zAttachTarget);
  1906   1906         }else{
  1907   1907           zComment = mprintf("Delete attachment \"%h\" from wiki page [%h]",
  1908   1908                p->zAttachName, p->zAttachTarget);
  1909   1909         }
  1910   1910         db_multi_exec(
  1911   1911           "REPLACE INTO event(type,mtime,objid,user,comment)"
................................................................................
  1913   1913           p->rDate, rid, p->zUser, zComment
  1914   1914         );
  1915   1915         free(zComment);
  1916   1916       }else{
  1917   1917         char *zComment;
  1918   1918         if( p->zAttachSrc && p->zAttachSrc[0] ){
  1919   1919           zComment = mprintf(
  1920         -             "Add attachment [%R/artifact/%S|%h] to ticket [%S]",
         1920  +             "Add attachment [/artifact/%S|%h] to ticket [%S]",
  1921   1921                p->zAttachSrc, p->zAttachName, p->zAttachTarget);
  1922   1922         }else{
  1923   1923           zComment = mprintf("Delete attachment \"%h\" from ticket [%.10s]",
  1924   1924                p->zAttachName, p->zAttachTarget);
  1925   1925         }
  1926   1926         db_multi_exec(
  1927   1927           "REPLACE INTO event(type,mtime,objid,user,comment)"