Fossil

Check-in [1f4b4fcb]
Login

Check-in [1f4b4fcb]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fixed a use of fclose() on a handle opened with popen(), noticed by Stephan Beal.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 1f4b4fcb62a9c3297cd865adbca655edb9ab71648d1648b6ffdaedcfd6615eee
User & Date: wyoung 2018-12-04 23:08:20
Context
2018-12-07
19:36
Reworded 2 references to 40-character artifact IDs, since those particular IDs may now be longer than 40 characters. ... (check-in: 565c2173 user: stephan tags: trunk)
2018-12-04
23:08
Fixed a use of fclose() on a handle opened with popen(), noticed by Stephan Beal. ... (check-in: 1f4b4fcb user: wyoung tags: trunk)
23:00
The new blockquote tinting feature of the default skin now works in the forum post editor screen as well, not just in the forum post display screen. ... (check-in: 19bb3b88 user: wyoung tags: trunk)
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/alerts.c.

︙︙
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858

      emailerError(p, "Failed to insert email message into output queue.\n"
                      "%s", sqlite3_errmsg(p->db));
    }
  }else if( p->zCmd ){
    FILE *out = popen(p->zCmd, "w");
    if( out ){
      fwrite(blob_buffer(&all), 1, blob_size(&all), out);
      fclose(out);
    }else{
      emailerError(p, "Could not open output pipe \"%s\"", p->zCmd);
    }
  }else if( p->zDir ){
    char *zFile = file_time_tempname(p->zDir, ".email");
    blob_write_to_file(&all, zFile);
    fossil_free(zFile);








|








844
845
846
847
848
849
850
851
852
853
854
855
856
857
858

      emailerError(p, "Failed to insert email message into output queue.\n"
                      "%s", sqlite3_errmsg(p->db));
    }
  }else if( p->zCmd ){
    FILE *out = popen(p->zCmd, "w");
    if( out ){
      fwrite(blob_buffer(&all), 1, blob_size(&all), out);
      pclose(out);
    }else{
      emailerError(p, "Could not open output pipe \"%s\"", p->zCmd);
    }
  }else if( p->zDir ){
    char *zFile = file_time_tempname(p->zDir, ".email");
    blob_write_to_file(&all, zFile);
    fossil_free(zFile);
︙︙