Fossil

Check-in [e806e5c4]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fixed a bug in the onclick handler for the new hamburger button which allowed the browser to follow our empty 'a href="#"' link. For some reason, Chrome only did this sometimes, not always, which lead to me thinking it was some kind of race condition.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | js-hamburger-menu
Files: files | file ages | folders
SHA3-256:e806e5c4df71f2e998e9524ba4237d39e95a6b1befa9ba8e5ae78efd33048c26
User & Date: wyoung 2018-09-05 23:45:11
Original Comment: Fixed a bug in the onclick handler for the new hamburger button which allowed the browser to follow our empty link. For some reason, Chrome only did this sometimes, not always, which lead to me thinking it was some kind of race condition.
Context
2018-09-06
03:56
Converted src/href.js to jQuery as a demonstration: the code's nearly half the size, and it's clearer as a result. check-in: 59c7ca05 user: wyoung tags: js-hamburger-menu
2018-09-05
23:45
Fixed a bug in the onclick handler for the new hamburger button which allowed the browser to follow our empty 'a href="#"' link. For some reason, Chrome only did this sometimes, not always, which lead to me thinking it was some kind of race condition. check-in: e806e5c4 user: wyoung tags: js-hamburger-menu
23:08
Ajaxy animated drop-down menu on clicking a new hamburger button in the default skin, as requested by drh on the forum: https://fossil-scm.org/forum/forumpost/40a18bd742

Initial version uses jQuery loaded from Google Hosted APIs for ease of development. check-in: d7c43c5a user: wyoung tags: js-hamburger-menu

Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to skins/default/footer.txt.

30
31
32
33
34
35
36

37
38
39
          needSitemapHTML = false;
          showPanel();
        });
      }
      else {
        showPanel();   // just show what we built above
      }

    });
  })();
</script>







>



30
31
32
33
34
35
36
37
38
39
40
          needSitemapHTML = false;
          showPanel();
        });
      }
      else {
        showPanel();   // just show what we built above
      }
      return false;  // prevent browser from acting on <a> click
    });
  })();
</script>