Fossil

Timeline
Login

Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 check-ins for the month beginning 2018-08-01 by user wyoung

Following month ↑
2018-08-29
03:31
Fixed some Markdown-isms just checked into www/forum.wiki. ... (check-in: 34a3bc12 user: wyoung tags: trunk)
03:25
Assorted improvements to the "Skin Setup" section of forum.wiki. ... (check-in: 04d4bde1 user: wyoung tags: trunk)
03:13
Clarity fixes to the Email Alerts capability paragraph of forum.wiki ... (check-in: d6e5754d user: wyoung tags: trunk)
2018-08-26
03:35
Applied the new CSP nonce to the <script> tags in the header for the Enhanced Original, Eagle, and Xekri skins, else the clock in the upper right breaks and Chrome gives an error about the CSP violation. ... (Closed-Leaf check-in: b9d86ed2 user: wyoung tags: csp-nonce)
2018-08-25
20:41
Coloring the hyperlinks to the newest forum posts from /forum with a dimmer and less saturated version of the normal hyperlink color in the default skin, to test the new div.forumPosts selector. Other skins to be updated later if this is approved. ... (check-in: 86ff84da user: wyoung tags: trunk)
17:24
Merged forum-skin-links branch to trunk. ... (check-in: 91c2b1b6 user: wyoung tags: trunk)
16:06
Added new CSS class forumPosts to the
containing the list of posts on the /forum page so that skins can target elements of this list differently than others. One immediate use for this is styling read threads differently via a:visited styling. Currently, only one of the stock skins ships with an unconditional a:visited change, so that all links show in the same color regardless of their state. That's fine in most areas of the UI, but in the forum, a skin developer may want something special, so we need a way to mark them differently. This
was already using the broadly-used "fileage" style, but we don't want changes to a:visited and such to affect all other users of fileage, so we need a unique style to this page.
... (check-in: 77782490 user: wyoung tags: trunk)
2018-08-17
01:27
Allow + signs in email addresses. Added a comment to link to a source giving the true limit on legal characters in email addresses, which are currently far less restrictive than our newly-expanded limits. ... (check-in: 1bfd7903 user: wyoung tags: trunk)
2018-08-16
07:21
Improved locality of a variable. No functional change. ... (check-in: 09103fd2 user: wyoung tags: trunk)
07:06
Posts are now hidden on the /forum page if they're marked as private (i.e. needing moderator attention) and they were posted by another user, except when the user is a moderator.

(Closed because a different method was implemented on trunk.) ... (Closed-Leaf check-in: 779eaaae user: wyoung tags: hide-post-if-needmod)

06:36
Replaced a declare-and-init line pair with a single define-with-value line. No functional change. ... (check-in: 8f47c3f6 user: wyoung tags: trunk)
2018-08-14
05:59
Changed all of the "sendmail -t" commands to "sendmail -ti" to make it ignore lines containing only a dot; we use EOF to signal "end of message," so we don't need the second signal. This is separate from the smtp.c fix in [51740ce45f]: that's only used when Fossil speaks directly to an SMTP server, where a leading dot is treated somewhat differently than the lone dot rule for sendmail(1)'s stdin.

This problem with leading dots was diagnosed by gumblex, /forumpost/4290f75ba1. ... (check-in: 8c0ec30b user: wyoung tags: trunk)

04:39
URL fix ... (check-in: 6787aac9 user: wyoung tags: trunk)
03:55
The blob-to-SMTP encoding logic was not strictly following RFC 5321 in that it was only dealing with the lone dot on the line case, doubling it to prevent the SMTP server from interpreting that as end-of-message. It missed the case where, if anything follows the dot, SMTP drops the leading dot, so you must also double the leading dot in that case. Basically, you always double a leading dot, regardless of line length.

This only affects Fossil's direct-to-SMTP email sending case, not those that send via a piped command or via DB. That is dealt with later in [8c0ec30bc3]. ... (check-in: 51740ce4 user: wyoung tags: trunk)

2018-08-13
03:51
Covered capability 7 in the forum.wiki document, and made several improvements to the "Using the Moderation Feature" section. ... (check-in: 31631b75 user: wyoung tags: trunk)
03:23
Assorted minor improvements to the www/alerts.md document. The major one is re-emphasizing the need to give capability 7 to some user or user category. Ask me how I came to think this necessary. :) ... (check-in: 3e75a683 user: wyoung tags: trunk)
01:11
Typo fix ... (check-in: c3d9c8e0 user: wyoung tags: trunk)
00:59
More forum.wiki tweaks ... (check-in: 26424763 user: wyoung tags: trunk)
00:31
Assorted improvements to the forum.wiki document, mainly to the new moderation material. ... (check-in: c1be5508 user: wyoung tags: trunk)
2018-08-12
23:24
Added the "How Moderation Works" section to www/forum.wiki, and improved the newly-renamed "Using the Moderation Feature" section as a result. ... (check-in: 812dd52c user: wyoung tags: trunk)
22:27
Added "id"s to every header tag in the forum.wiki document, so you can create links to sub-sections. ... (check-in: 03c298dc user: wyoung tags: trunk)
21:40
Fixed a few references to MIME type "text/x-fossil" in the fileformat document. It's "text/x-fossil-wiki" everywhere else. ... (check-in: e00cdbe7 user: wyoung tags: trunk)
21:35
Add /forum link to sitemap if user has RdForum capability ... (check-in: 5ad7222f user: wyoung tags: trunk)
06:11
URL fix in forum.wiki ... (check-in: 542c5576 user: wyoung tags: trunk)
03:21
Added the "Moderation" section to www/forum.wiki ... (check-in: e06e7f84 user: wyoung tags: trunk)
03:00
Assorted tweaks and improvements to the new email alerts material in www/forum.wiki. ... (check-in: 4326f76f user: wyoung tags: trunk)
02:47
Added the "Email Notification" section to the forum.wiki document. ... (check-in: 6b275203 user: wyoung tags: trunk)
2018-08-11
21:04
Added forumSel adjustment advice to forum.wiki. ... (check-in: 0194fb67 user: wyoung tags: trunk)
20:49
The periodic "updateClock()" call made in the header for several of the built-in skins (Eagle, Enhanced1, and Xekri) violates the new stricter CSP, since it requires a JS eval. We don't need an eval here: we can pass the function's name literally to window.setTimeout instead, which treats it as a Function object, which doesn't need to be eval'd. ... (check-in: eac15b4c user: wyoung tags: trunk)
19:43
Added the "Enable Forum Search" section to www/forum.wiki ... (check-in: cc5d2e1f user: wyoung tags: trunk)
19:28
Zeroed a pointer in its declaration to squish a warning from GCC 4.8.4 on Ubuntu 14.04 about use of a potentially uninitted pointer. I don't think it's actually possible for the current code to use the pointer in the window between its declaration and first use, but I think we can afford the extra machine instruction this will cost us. (I assume newer GCCs are smart enough to analyze this situation correctly, which is why the warning hasn't been squished earlier.) ... (check-in: 892781cb user: wyoung tags: trunk)
16:59
Fix to checkin [8c91be8b], which was intended to allow the user to log in with the email found in the contact info field of the user table. That checkin is fine as far as it goes, but it only works if the caller doesn't subsequently try to use the passed user name for anything else, since it isn't actually a user name. This checkin causes the low-level login checking function to re-point the user name pointer at the actual login name discovered while scanning for matching email addresses. ... (check-in: 33522ff4 user: wyoung tags: login-with-email)
2018-08-09
06:59
Minor improvements to forum.wiki ... (check-in: 635d2f63 user: wyoung tags: trunk)
06:17
Tightned up the login-groups sub-section of the SSO section in forum.wiki. ... (check-in: 60c586d7 user: wyoung tags: trunk)
06:13
Tightened up the MTA point in www/forum.wiki, and added a bit about digest delivery. ... (check-in: b51d6212 user: wyoung tags: trunk)
06:04
More feature rah-rah in www/forum.wiki, plus better formatting. ... (check-in: cce5da16 user: wyoung tags: trunk)
04:34
Clarity pass on the forum capability names in www/forum.wiki to match nomenclature on the Admin -> Users page. ... (check-in: 2490bfba user: wyoung tags: trunk)
03:35
Added point about multiple copies of each matching post in web search results to the forum.wiki doc. ... (check-in: 89ab99e3 user: wyoung tags: trunk)
2018-08-08
19:43
More SSO discussion improvements in forum.wiki ... (check-in: bc303c0e user: wyoung tags: trunk)
19:30
More tweaks to the forum.wiki doc ... (check-in: 5d75504a user: wyoung tags: trunk)
19:25
Small tweak to the advice for "reader" category capability for forums ... (check-in: ea67aade user: wyoung tags: trunk)
19:22
Added the "Skin Setup" section to the new forum.wiki document ... (check-in: 3ec8f0a9 user: wyoung tags: trunk)
19:09
Expanded the SSO discussion in the new forum.wiki document ... (check-in: dd0a2dd3 user: wyoung tags: trunk)
18:58
Fixed some incorrect uses of Markdown backticks in a document declared as wiki format. ... (check-in: 76ca1f82 user: wyoung tags: trunk)
18:55
Link fix in previous ... (check-in: be74f259 user: wyoung tags: trunk)
18:52
Several improvements to the new forum.wiki document ... (check-in: f85bc326 user: wyoung tags: trunk)
18:32
Typo fix ... (check-in: 15b20343 user: wyoung tags: trunk)
18:29
Fixed some Markdown formatting problems in www/emaildesign.md. Made a few minor grammar tweaks while in there. ... (check-in: 30716e3c user: wyoung tags: trunk)
17:21
Added initial version of www/forum.wiki document and a link to it from the front page. ... (check-in: 4ed14b1f user: wyoung tags: trunk)
13:19
Added Forum navbar before Tickets in all skins that had such a link, pointing to /forum if the user is anonymous and has capability 2 or 3, or is logged in and has any capabilities in 2-6 inclusive. ... (Closed-Leaf check-in: 4344f806 user: wyoung tags: forum-skin-links)
Previous month ↓