Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
54 check-ins for the month beginning 2022-02-01 by user george
Following month ↑|
2022-02-23
| ||
| 12:33 | Count overnesting as the fourth type of the footnote-related issues and report accordingly. ... (check-in: ae297bb6 user: george tags: markdown-footnotes) | |
| 09:45 |
Minor refactoring. Move the definition of BLOB_APPEND_LITERAL()
macro from markdown_html.c to blob.c so that
it could be used outside of markdown_html.c.
Also rename it to lowercase for consistency with other API.
Within markdown.c use that newly available macro instead of
blob_append_string().
Within markdown_html.c use it for footnotes-relevant code.
Other invocations of BLOB_APPEND_LITERAL() within
markdown_html.c are left intact (they use an alias) in order to
simplify the potential merge with the trunk.
...
(check-in: c8a8d0c9 user: george tags: markdown-footnotes)
| |
| 08:21 |
Minor refactoring. Move the definition of BLOB_APPEND_BLOB()
macro from markdown_html.c to blob.c so that
it could be used outside of markdown_html.c.
Also rename it to blob_appendb() for consistency with
blob_appendf() and other API.
Within markdown.c use that newly available macro where appropriate.
Within markdown_html.c use it for footnotes-relevant code.
Other invocations of BLOB_APPEND_BLOB() within
markdown_html.c are left intact (they use an alias) in order to
simplify the potential merge with the trunk.
...
(check-in: 33a681eb user: george tags: markdown-footnotes)
| |
| 07:36 | Fix handling of user-provided classes for unreferenced, joined and overnested footnotes. In all these cases the tokens of user-provided classes are rendered as plain-text and no special classes are added anywhere. ... (check-in: 875472a8 user: george tags: markdown-footnotes) | |
|
2022-02-21
| ||
| 05:14 |
Add a comment for append_footnote_upc().
Also substitute a variable of zero value with just "0" constant.
No functional changes.
...
(check-in: ae8a3dd5 user: george tags: markdown-footnotes)
| |
| 04:29 | Impose a limit on the depth of nesting of inline footnotes. Also add a few test cases: for depth limiting and HTML hijacking. ... (check-in: f4ff013a user: george tags: markdown-footnotes) | |
|
2022-02-20
| ||
| 23:00 |
If there are issues with footnotes then set TH1 variable $footnotes_issues_counters
to a space separated list of integers that count for "misref", "unref" and "joins".
This eliminates the need for JavaScript for the case when a custom skin
wants to warn about issues with footnotes
in the header of a page. Also fix counting of "joins": count the number of unique labels that have multiple definitions (and not the number of such definitions). ... (check-in: 773cef5c user: george tags: markdown-footnotes) | |
|
2022-02-19
| ||
| 01:59 |
Fix hyperlinks on the /winfo page. These were broken
when a page was accessed through /info/HASH
or /winfo/HASH aliases.
...
(check-in: 356a4845 user: george tags: trunk)
| |
| 01:16 | Parse inline footnotes even if a renderer does not define a callback for rendering of footnote markers. This seems more correct even though the current implementation of backlink processor does define such callback as an empty function. ... (check-in: e06c12d1 user: george tags: markdown-footnotes) | |
| 01:00 |
Handle some corner cases more thoroughly: dismiss empty footnotes,
passthrough (more carefully) user-provided classlist if the token
is not followed by a blank character or if a footnote's text consists
just of such token and blank characters. Also simplify a little bit
a few places inside of is_footnote() function.
...
(check-in: fe315780 user: george tags: markdown-footnotes)
| |
|
2022-02-18
| ||
| 01:33 |
Add --lint-footnotes option to the test-markdown-render
command. If this flag is given and footnotes in the input have issues, then
print to stderr the counters of "misrefs", "strays" and "split-defs"
and exit with error. This should partially address a concern
raised at the forum.
...
(check-in: 1f525713 user: george tags: markdown-footnotes)
| |
|
2022-02-17
| ||
| 22:09 | If a footnote's text starts with a token of the special form then use this token to derive a set of CSS classes that are added to that footnote and its references. This enables users to style elements of a particular footnote provided that the administrator provisioned and documented some special CSS classes in a custum skin. Default skin does not provide any of such special classes which makes this feature an "opt-in". ... (check-in: 92516ced user: george tags: markdown-footnotes) | |
| 00:17 | Clean-up and rephrase some comments. ... (check-in: a62c8768 user: george tags: markdown-footnotes) | |
|
2022-02-16
| ||
| 23:08 | Make parsing slightly faster and fix a comment. No changes in functionality. ... (check-in: a36dd09d user: george tags: markdown-footnotes) | |
| 22:11 |
Include REQUEST_URI into footnotes' hyperlinks.
This should make links work even if base href (in a page's header)
is not consistent with the REQUEST_URI.
If FOOTNOTES_WITHOUT_URI macro is defined while
compiling src/markdown_html.c then bare "#fragment"
hyperlinks (without REQUEST_URI) are generated.
...
(check-in: 2c1f8f35 user: george tags: markdown-footnotes)
| |
|
2022-02-15
| ||
| 21:35 | FIXME-comments in the code did not indicate issues and are now rephrased to be mere reminders. ... (Leaf check-in: d253ece0 user: george tags: base-href-fix) | |
| 02:26 | Do not override base href for wiki pages. This needs testing. ... (check-in: 89dd3451 user: george tags: base-href-fix) | |
| 00:58 |
When setting $webpagename pass the value of g.zPath
though escape_quotes(). This is unclear how g.zPath
can contain quotes but let this strange case be handled in a safe way.
...
(check-in: 288fe34c user: george tags: base-href-fix)
| |
| 00:14 |
Move <meta charset="UTF-8"> to the begining of the default header.
Supply BODY element with a class that derives from $webpagename.
...
(check-in: 6d135904 user: george tags: base-href-fix)
| |
|
2022-02-14
| ||
| 23:32 |
Minor code refactoring: rename a temporary variable and utilize
matching_bracket_offset() one more time.
No changes in functionality.
...
(check-in: 5b845a07 user: george tags: markdown-footnotes)
| |
| 23:06 |
Do not export g.zRelReqURI to TH1 interpreter because
getParameter proc can retrieve PATH_INFO
and QUERY_STRING. Instead export g.zPath
(as $webpagename) since that is typically needed in
the TH1 headers/footers of custom skins.
...
(check-in: ff4c7ed6 user: george tags: base-href-fix)
| |
| 22:43 |
Make style_set_base_href_suffix() safe for misuse:
if the resulting suffix contains unescaped quotes then escape them.
$base_href_suffix is intended for interpolation inside
of the quoted href attribute. This check-in should address the case
when a user of malfunctioning browser (which mishandles quoting)
is tricked by an adversary to visit a specially crafted hyperlink.
...
(check-in: d97752f3 user: george tags: base-href-fix)
| |
|
2022-02-13
| ||
| 19:29 | Fix parsing of "free-standing" footnotes that was (slightly) broken by the previous check-in. ... (check-in: 23c3e0b2 user: george tags: markdown-footnotes) | |
| 17:54 | Rename variable g.zUrlSuffix to g.zRelReqURI (Relative Request URI). Provide it to TH1 interpreter as $relrequri. ... (check-in: 05e3fa76 user: george tags: base-href-fix) | |
| 16:00 |
Fix hyperlinks on the /winfo page. These were broken when a page was rendered through /info/HASH of /winfo/HASH aliases.
...
(check-in: 5ce372ce user: george tags: base-href-fix)
| |
| 01:35 |
Cherry-pick from branch 'cgi-compliance' (and thus back out [5bb921dd0893a548]).
Adapt the computation of g.zUrlSuffix in set_base_url() accordingly.
...
(check-in: 5c649c7e user: george tags: base-href-fix)
| |
|
2022-02-12
| ||
| 21:51 |
Add an overlooked call to style_set_base_href_suffix() in src/info.c and add a comment of why not to do so for /ext
...
(check-in: 87fba731 user: george tags: base-href-fix)
| |
| 20:52 | If markup is ambigous between a "span-bounded" footnote and a "free-standing" footnote followed by another footnote then interpret as the later case. ... (check-in: b363a4db user: george tags: markdown-footnotes) | |
| 19:53 |
An attepmt to fix the
<base href="...">
element of webpages so that the value of href attribute
matches the URL being served.
This should fix "#fragment" hyperlinks on all pages where these
were broken (all except /doc).
The values for /wiki and
/info were left unchanged
(it's yet unclear if they should also be changed).
...
(check-in: 03b39f1d user: george tags: base-href-fix)
| |
|
2022-02-11
| ||
| 01:26 | Fix parsing of a multiline definition of labeled footnote for the case when lines end with CR+LF. ... (check-in: ea66d15c user: george tags: markdown-footnotes) | |
|
2022-02-10
| ||
| 23:30 | Fix a warning for unused variable 'p' introduced by [487e465263fd21] ... (check-in: 8895d938 user: george tags: trunk) | |
| 23:00 | Clean-up and polish relevant CSS and HTML's class names. Insure visual spacing between footnotes' markers so that numbers are distinguishable when multiple footnotes in a row are used. Factor out auxiliary decorations from HTML into the default CSS, to enable customization via skins. ... (check-in: 2b1375ab user: george tags: markdown-footnotes) | |
| 00:29 | Merge from trunk ... (Leaf check-in: 2b5f9b21 user: george tags: search-terms-highlighting) | |
| 00:22 | Merge from trunk ... (Leaf check-in: a961a67b user: george tags: rptview-submenu-paralink) | |
| 00:17 | Merge from trunk ... (check-in: 88ff4e5d user: george tags: wcontent-subsets) | |
| 00:12 | Merge from trunk ... (Leaf check-in: 9b76469b user: george tags: th1-doc-vars) | |
| 00:05 | Remove unused local variable from cgi_parse_POST_JSON() to fix a compiler warning. ... (check-in: 96bf76a4 user: george tags: trunk) | |
|
2022-02-09
| ||
| 22:59 | Handle unreferenced footnotes. If a labeled footnote is defined but there are no references to it, then add a special item at the end of footnotes. This item includes a label and the text of the strayed footnote - both rendered verbatim via html_escape(). Default skin makes such items visible and easily distinguishable. The order of such items match the order in the underlying source code. ... (check-in: ada55cd4 user: george tags: markdown-footnotes) | |
| 20:09 | Join duplicated footnotes slightly faster. Fix a comment about auxiliary cmp_footnote_id() function. ... (check-in: 7f6a6418 user: george tags: markdown-footnotes) | |
| 19:38 | Fix a misuse of an unsigned integer in the blobReallocMalloc() which can lead to redundant memory reallocations. ... (check-in: 92221aaa user: george tags: markdown-footnotes) | |
| 19:29 | Fix a bug in the blob_reserve() function that was introduced by [1243bf39996b8a]. The current mainline is not affected because this function is not used anywhere. However it was causing memory corruption on the 'markdown-footnotes' branch since it was employed in [544df852b2d9a1]. ... (check-in: 7283ae6e user: george tags: markdown-footnotes) | |
|
2022-02-08
| ||
| 14:09 | An attempt to fix a "double free crash" from the previous check-in. ... (check-in: 18c9d103 user: george tags: markdown-footnotes) | |
| 14:04 |
If several footnotes are defined with the same label then join them into a single footnote. Text from each definition becomes an item in the list. This solution makes such situations noticable for the usual case (when this is an oversight) but also not obtrusive for the rare cases (when this is intentional). The list is provided with a special class to enable styling via skin customization. This check-in is known to cause crash, see the forthcoming check-in. ... (check-in: 544df852 user: george tags: markdown-footnotes) | |
| 13:39 | Add const qualifier to the arguments of the blob_compare() function. ... (check-in: 2822b63b user: george tags: markdown-footnotes) | |
|
2022-02-06
| ||
| 22:53 | Handle misreferences more thoroughly. Implement support of footnotes-within-footnotes with (hopefully) proper crosslinking (that's where it's getting tricky). ... (check-in: 1787f6df user: george tags: markdown-footnotes) | |
|
2022-02-04
| ||
| 23:07 | Handle misreferences: a reference to undefined footnote. ... (check-in: 28e6a9cd user: george tags: markdown-footnotes) | |
| 19:47 | Minor code refactoring. ... (check-in: 2636e224 user: george tags: markdown-footnotes) | |
| 19:24 | Automatically render a horizontal rule before the list of footnotes. If desired a particular skin can hide it using CSS selector "hr.footnotes-separator". ... (check-in: 6807b434 user: george tags: markdown-footnotes) | |
| 19:08 | Add file test/markdown-test3.md that is suggested as an accumulator of footnotes-specific test cases. ... (check-in: fe9e6ff9 user: george tags: markdown-footnotes) | |
| 17:28 | For rendering a numeric footnote mark enclose HTML tag "a" inside of tag "sup" (instead of the opposite) and format anchor's id using "noteref%s-%i-%s" template (instead of "noteref-%s%i-%s"). Add highlighting when hovering over a span-bounded footnotes. ... (check-in: fb999972 user: george tags: markdown-footnotes) | |
| 16:54 | Fix documentation so that an example of a referenced footnote definition inside of the fenced code block is not recognized as a real footnote defenition. This demonstrates a subtle gotcha and a possible work-arround of it. ... (check-in: 7229d0f5 user: george tags: markdown-footnotes) | |
| 00:37 | Switch to (^...) for inline footnotes. Implement span-specific footnotes. Add documentation. ... (check-in: cae7a5d1 user: george tags: markdown-footnotes) | |
|
2022-02-02
| ||
| 17:50 | Bug-fix: Do not loose referenced footnotes when inline footnotes are also used. ... (check-in: a8f0f1e7 user: george tags: markdown-footnotes) | |
|
2022-02-01
| ||
| 20:12 | Support multiline footnote definitions and inline footnotes via ^[...] syntax (this syntax is not settled yet). Fix overall link support that was broken by [e3710ccd3a5a]. ... (check-in: 78b7846b user: george tags: markdown-footnotes) | |