Fossil

Check-in [5f32bf71]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Include the filename in the form action when redirected from login required to avoid needing to use Content-Disposition header to hint the client what the filename is.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | pending-review
Files: files | file ages | folders
SHA1:5f32bf719d7440d33ed3cc07e7f5196d53f95683
User & Date: andybradford 2015-11-28 19:59:59
Context
2015-11-29
03:51
Fix incorrect form generation for zip pages from redirected anonymous login. This only happens when the zip permission is only allowed after anonymous login is successful. check-in: 167dec48 user: andybradford tags: trunk
2015-11-28
19:59
Include the filename in the form action when redirected from login required to avoid needing to use Content-Disposition header to hint the client what the filename is. Closed-Leaf check-in: 5f32bf71 user: andybradford tags: pending-review
2015-11-24
23:41
Fix compiler warnings seen with MSVC. Add comments. check-in: 52e3d9d8 user: mistachkin tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/zip.c.

473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
  rid = name_to_typed_rid(nRid?zRid:zName,"ci");
  if( rid==0 ){
    @ Not found
    return;
  }
  if( referred_from_login() ){
    style_header("ZIP Archive Download");
    @ <form action='%R/zip'>
    cgi_query_parameters_to_hidden();
    @ <p>ZIP Archive named <b>%h(zName).zip</b> holding the content
    @ of check-in <b>%h(zRid)</b>:
    @ <input type="submit" value="Download" />
    @ </form>
    style_footer();
    return;







|







473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
  rid = name_to_typed_rid(nRid?zRid:zName,"ci");
  if( rid==0 ){
    @ Not found
    return;
  }
  if( referred_from_login() ){
    style_header("ZIP Archive Download");
    @ <form action='%R/zip/%h(zName).zip'>
    cgi_query_parameters_to_hidden();
    @ <p>ZIP Archive named <b>%h(zName).zip</b> holding the content
    @ of check-in <b>%h(zRid)</b>:
    @ <input type="submit" value="Download" />
    @ </form>
    style_footer();
    return;