Fossil

Check-in [5eea3db6]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix the object ID decoding on the /info page. Ticket [a5403e6eee].
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:5eea3db6c19f5185409adf301e129dbefa08c998
User & Date: drh 2010-01-20 15:48:21
References
2010-01-20
15:50 Fixed ticket [a5403e6e]: Clicking on ticket link on Timeline page redirects to Index Page. plus 2 other changes artifact: 74eada78 user: drh
Context
2010-01-20
16:25
Add the --cherrypick option to the trunk. I had intended to put the previous check-in on the truck but mistakenly left the local repository on the ssl branch. Fortunately, I was able to use to new --cherrypick option to pull the changes over into trunk without pulling all ssl changes. check-in: d2204a00 user: drh tags: trunk
15:56
Pull in the latest fixes from the trunk. check-in: ac8902be user: drh tags: ssl
15:55
Pull in the latest fixes from the trunk. check-in: a3161f5f user: drh tags: clear-title
15:48
Fix the object ID decoding on the /info page. Ticket [a5403e6eee]. check-in: 5eea3db6 user: drh tags: trunk
15:43
Fix a memory leak in the check-out logic that prevents opening of massive repositories. Ticket [708eab9d48] check-in: 726a13d2 user: drh tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/info.c.

  1058   1058   void info_page(void){
  1059   1059     const char *zName;
  1060   1060     Blob uuid;
  1061   1061     int rid;
  1062   1062     
  1063   1063     zName = P("name");
  1064   1064     if( zName==0 ) fossil_redirect_home();
         1065  +  if( validate16(zName, strlen(zName))
         1066  +   && db_exists("SELECT 1 FROM ticket WHERE tkt_uuid LIKE '%q%%'", zName) ){
         1067  +    tktview_page();
         1068  +    return;
         1069  +  }
  1065   1070     blob_set(&uuid, zName);
  1066   1071     if( name_to_uuid(&uuid, 1) ){
  1067   1072       fossil_redirect_home();
  1068   1073     }
  1069   1074     zName = blob_str(&uuid);
  1070         -  if( db_exists("SELECT 1 FROM ticket WHERE tkt_uuid='%s'", zName) ){
  1071         -    tktview_page();
  1072         -    return;
  1073         -  }
  1074   1075     rid = db_int(0, "SELECT rid FROM blob WHERE uuid='%s'", zName);
  1075   1076     if( rid==0 ){
  1076   1077       style_header("Broken Link");
  1077   1078       @ <p>No such object: %h(zName)</p>
  1078   1079       style_footer();
  1079   1080       return;
  1080   1081     }