Fossil

Check-in [a5840849]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fixed bug computing a symbol's parent. preferedparent is the voting table, not the home of the definite information. The bug caused the use of the wrong parent lod during the import of changesets. Luckily the chosen parent was not known yet, causing an abort.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1:a5840849d0e3ceb04bf6f5b922d4d1fddc0e82ff
User & Date: aku 2008-02-06 04:57:30
References
2008-03-05
03:24
Reverting the change of [a5840849d0]. Use of 'preferedparent' is ok. The problem I attempted to fix is properly fixed by looking at the branch changesets as well during import, and by acknowledging that there can be branches which have no changesets committed to them. check-in: 99004d57 user: aku tags: trunk
Context
2008-02-06
04:58
Updated my notes tracking the known problems. check-in: 9f297fed user: aku tags: trunk
04:57
Fixed bug computing a symbol's parent. preferedparent is the voting table, not the home of the definite information. The bug caused the use of the wrong parent lod during the import of changesets. Luckily the chosen parent was not known yet, causing an abort. check-in: a5840849 user: aku tags: trunk
04:55
Get the line of development for changesets directly from the items and their lod references. The in-memory data from the meta table is out-of-date since the adjustment of parents in pass 'FilterSymbols'. Print the LOD information when sorting the changesets. check-in: 0d13da30 user: aku tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to tools/cvs2fossil/lib/c2f_psym.tcl.

44
45
46
47
48
49
50
51
52
53





54
55
56
57
58
59
60
    method id   {} { return $myid   }

    method istrunk {} { return 0 }

    method parent {} {
	return [$myproject getsymbol [state one {
	    SELECT S.name
	    FROM preferedparent P, symbol S
	    WHERE P.sid = $myid
	    AND   S.sid = P.pid





	}]]
	return
    }

    # # ## ### ##### ######## #############
    ## Symbol type








|
|
|
>
>
>
>
>







44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
    method id   {} { return $myid   }

    method istrunk {} { return 0 }

    method parent {} {
	return [$myproject getsymbol [state one {
	    SELECT S.name
	    FROM tag T, symbol S
	    WHERE T.sid = $myid
	    AND   S.sid = T.lod
	UNION
	    SELECT S.name
	    FROM branch B, symbol S
	    WHERE B.sid = $myid
	    AND   S.sid = B.lod
	}]]
	return
    }

    # # ## ### ##### ######## #############
    ## Symbol type