Fossil

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

200 most recent check-ins that include changes to files matching 'src/*'

2018-10-20
15:00
Fixed an off-by-one error in the error log header printer, resulting in the day number being for the next day past the call time. Bug diagnosis and fix from https://fossil-scm.org/forum/forumpost/0d5933da4c check-in: cf9b44a9 user: wyoung tags: trunk
2018-10-19
22:37
Now that type has changed due to [d0fa9eee56], cast back to match total variable. check-in: 77371043 user: andybradford tags: trunk
22:12
Use a signed type to avoid an infinite loop in socket_send(); socket_receive() is already fine. check-in: d0fa9eee user: andybradford tags: trunk
2018-10-17
23:53
Enhance the security-audit page to detect insecurities resulting from having self-registration enabled. This is a work in progress. More testing and more checks are needed in this area. check-in: 724ccc46 user: drh tags: trunk
14:16
Modify the comment formatter to avoid output of incomplete UTF-8 sequences, and to avoid line breaks inside UTF-8 sequences. See https://fossil-scm.org/forum/forumpost/1247e4a3c4 for detailed information and tests. Leaf check-in: 1bbca2c3 user: florian tags: comment-formatter-utf8
2018-10-12
16:14
Fix a comment on the "html" and "puts" TH1 commands. Before this fix, the meanings of the two commands were reversed. check-in: 35563f3d user: drh tags: trunk
2018-10-11
16:36
Extend the CSS fixes to avoid column breaks inside list items, [dc5e06ff71] and [51da396650], as Firefox classifies 'break-inside' as an 'invalid property name'. This affects the sitemap and the hamburger drop-down menu. check-in: 5bd8d6fe user: florian tags: js-hamburger-menu
09:39
Fix minor inaccuracy in the number of years in the human_readable_age() function. check-in: e93ae526 user: drh tags: trunk
2018-10-10
19:49
Applied a patch by forum user vor0nwe to allow the WYSIWYG wiki page editor to work in the face of the new CSP restrictions on inline JavaScript. The patch and explicit license for inclusion in Fossil are here: https://fossil-scm.org/forum/forumpost/6985a4754e check-in: 543cdd47 user: wyoung tags: trunk
16:42
Removed a period at the end of a sentence ending in a URL to avoid the need for cleverness in URL handling to get the correct document to open. (Affects "fossil help grep" output.) Problem noticed by jungleboogie on the forum, /forumpost/13332107cc.) check-in: fac3d6b0 user: wyoung tags: trunk
2018-10-09
16:06
Added a nonce attribute to the <script> tag for the inline JavaScript backing the WYSIWYG wiki editor feature. Without this, modern browsers throw a CSP violation. check-in: 12a90ff4 user: wyoung tags: trunk
13:57
Update to SQLite 3.25.2 final check-in: 04a21428 user: jan.nijtmans tags: trunk
12:28
Fix a conflict when syncing forum posts. check-in: 8a980fde user: drh tags: trunk
2018-10-06
17:10
Fixed an HTML typo in the /help page, reported by "Z03": (https://fossil-scm.org/forum/forumpost/13c80e13e2 check-in: 1f4a9eb9 user: wyoung tags: trunk
14:14
The "fossil help -o" command shows command-line options that are common to all commands. check-in: 50eb6bd5 user: drh tags: trunk
2018-10-04
14:56
On the /setup_ucap_list page, show the number of users having each capability, with a link to a list of users. This only works for administrators. check-in: 59442179 user: drh tags: trunk
13:45
Allow users with Forum Supervisor permission ('6') to add Forum Write Trusted permission ('4') to users as they are approving a post by that user. check-in: d33d446f user: drh tags: trunk
12:52
Remove the SQLITE_ENABLE_FTS3_PARENTHESIS compile-time option from default builds. This avoids problems that might arise when users type parentheses in search boxes that use FTS. check-in: 9dc49e61 user: drh tags: trunk
07:36
Avoided a crash in Fossil > Admin > Notification > Send Announcement triggered when no subscribers are set up, causing it to fail on Submit if you tell it to send the announcement to all subscribers. The check also guards against sending such things before email alerts are set up. In either case, the "Send Announcmeent" page gives an error pointing you to the docs, rather than a form that cannot be successfully submitted. check-in: ea646955 user: wyoung tags: trunk
07:13
Fixed an off-by-one error affecting "fossil grep" when the final argument was left off. check-in: f6502e8c user: wyoung tags: trunk
2018-10-03
20:11
URL fix check-in: 186748ff user: wyoung tags: trunk
20:09
Moved the documentation for Fossil's grep implementation out of src/regexp.c into a new document with greatly-expanded content, www/grep.md, which is now referenced both from the source code and in the output for "fossil help grep". check-in: 2e1775e2 user: wyoung tags: trunk
16:52
Remove uncommonly used commands from the set of "common" commands in the "fossil help" listing. check-in: 29313518 user: drh tags: trunk
2018-10-01
06:21
Merged branch libbind-ns-alternative: I haven't found any platform where this won't build. It doesn't enable libbind or use libresolv better on every platform where it might possibly work, but at the very least it avoids build errors everywhere I've tried it. check-in: 71c298f3 user: wyoung tags: trunk
2018-09-28
20:54
Document reference links having no second set of square brackets check-in: 2856830e user: andygoth tags: trunk
2018-09-27
02:17
Guess that agents with "iPad" in their name do not want the narrow screen versions of the page. check-in: b76eebea user: drh tags: trunk
2018-09-26
19:46
Update to SQLite 3.25.2 Leaf check-in: c7db0ee5 user: jan.nijtmans tags: openssl-1.1
18:45
"New Message" -> "New Thread" in forum. check-in: e11d3917 user: wyoung tags: trunk
18:39
Setup and Admin users that are in the subscriber table were getting email alerts only if they had explicit moderator capabilities set. Those with bare "s" or "a" weren't getting notified. check-in: 1d3dd1d9 user: wyoung tags: trunk
14:04
Enable the chronological forum display for all users able to read the forum. Make chronological the default display mode for mobile devices, as determined by the user-agent string. check-in: c720327a user: drh tags: trunk
13:33
When clicking on a username in the timeline, link to a timeline that shows *all* events for that user. In other words, override the display-cookie y= query parameter by providing an explicit y=a query term. check-in: 6313d0a8 user: drh tags: trunk
2018-09-25
17:26
Update the built-in SQLite to the 3.25.2 release candidate, for testing. check-in: 5fdd5312 user: drh tags: trunk
2018-09-22
19:37
Update to Fossil 2.7 check-in: 9d067b61 user: jan.nijtmans tags: openssl-1.1
17:09
Typo fix Closed-Leaf check-in: b6c490ce user: tangent tags: libbind-ns-alternative
17:02
Added a check for ns_parserr(), which we currently don't know how to find on OpenBSD. This also fixes a logic error in auto.def which would cause the warning that this feature won't be compiled to not be given. check-in: f99e7632 user: wyoung tags: libbind-ns-alternative
16:55
Removed the "Linux" platform test from the DNS MX stuff in src/smtp.c. You should always test for features, not platforms, and we've now got the feature tests we need to replace this too-broad platform test. check-in: 5358fe95 user: wyoung tags: libbind-ns-alternative
16:38
Replaced the call to the undocumented ns_name_uncompress() function with dn_expand(), which is documented, at least on OpenBSD, and it's shorter. Then made ns_name_uncompress() and __ns_name_uncompress() fallbacks for this, with suitable autosetup tests for all of it. check-in: d0fb5ac7 user: wyoung tags: libbind-ns-alternative
06:57
Fix to previous for CentOS 7. check-in: c7640b38 user: tangent tags: libbind-ns-alternative
06:46
The previous checkin on this branch prevented src/smtp.c from both building and linking because the code previously assumed that it could only build against libresolv for MX lookups and such on Linux, but the checkin gave it enough slack to *attempt* to build on macOS. This checkin prevents that from happening if run on stock macOS, but if you install libbind via Homebrew, it also opens up the possibilty to biuld against it for the first time. It's a complicated sequence of checks due to the way libbind interacts with the stock libresolv. This means we have yet more reason to want to test this widely before merging it to trunk. check-in: 4d9970f6 user: wyoung tags: libbind-ns-alternative
05:47
Added autosetup checks for alternative libraries and names for the res_query() and ns_*() functions that module smtp.c previously depended on finding in libresolv/glibc. Checking it in on a branch because it needs multiplatform testing. This version solves the problem originally reported on the forum by Andy Goth, being that the current trunk doesn't build on CentOS 5. check-in: ed3b1e4d user: wyoung tags: libbind-ns-alternative
2018-09-21
13:57
Avoid unnecessary quoting of ASCII characters 34 and 39 in the markdown formatter. check-in: 7950dc22 user: drh tags: trunk
2018-09-20
13:38
Update the built-in SQLite to version 3.25.1. check-in: c5abb962 user: drh tags: trunk
13:35
Fix the default CSS for the "columns" class to avoid breaking column breaks within a single <li> element. check-in: 51da3966 user: drh tags: trunk
10:31
Allow /sitemap to accept the popup query parameter as GET as long as the incoming request is from the same origin. This is probably sufficient to prevent revealing URLs to robots. And the use of GET seems to be more in keeping with the REST idea. check-in: 2804c71a user: drh tags: trunk
06:44
Backout of [e0cc10f03e518831]: Bring back default windows builds with OpenSSL 1.3 check-in: 9e03e513 user: jan.nijtmans tags: openssl-1.1
2018-09-19
20:19
Merge updates from trunk. check-in: 2269309f user: ashepilko tags: cmake-ide
19:55
Ignore errors in the clean target commands. check-in: 27c7a491 user: ashepilko tags: trunk
2018-09-18
19:37
Backout of [115544e97517f447]. Unbreaks the SSL enabled build for MSVC on Windows, due to OpenSSL build system changes that are not accounted for by the check-in. Also, there were crashes with MinGW produced binaries using OpenSSL 1.1.1. check-in: e0cc10f0 user: mistachkin tags: trunk
17:50
Added a missing db_finalize() call in /json/branch/list which led to a downstream segfault via an invalid/destructed Stmt handle. check-in: e45789ee user: stephan tags: trunk
15:50
Add the "fossil branch current" command. Also rearrange the code and the help text for the "fossil branch" command so that the various subcommands are in alphabetical order. check-in: 3b0a1f4e user: drh tags: trunk
2018-09-15
20:27
add support for TLS 1.3, when compiled with OpenSSL 1.1.1 (LTS). Windows build adapted to use OpenSSL 1.1.1 by default. Still compiles and runs with older OpenSSL as well check-in: 115544e9 user: jan.nijtmans tags: trunk
12:39
Update the built-in SQLite to the 3.25.0 release. check-in: 048a6f80 user: drh tags: trunk
2018-09-14
19:13
Merge updates from trunk. check-in: f59c9ecb user: ashepilko tags: cmake-ide
2018-09-11
17:47
Documentation updates for custom TH1 commands. check-in: 874a4dac user: mistachkin tags: trunk
14:54
merge trunk Closed-Leaf check-in: 368c78a8 user: jan.nijtmans tags: openssl-1.1
14:29
Compile openssl with option no-weak-ssl-ciphers (or -DOPENSSL_NO_WEAK_SSL_CIPHERS) Update custum Makefile.mingw check-in: 58b7b4e5 user: jan.nijtmans tags: trunk
00:52
Fixes to the new script element of skins. check-in: c22b71df user: drh tags: trunk
00:10
Add a hamburger menu that brings up an overlaid /sitemap to the default skin. check-in: 9c887998 user: drh tags: trunk
2018-09-10
23:57
Merge in the ability to define a script for a skin. check-in: 666c4f9a user: drh tags: js-hamburger-menu
23:47
Add the styleScript TH1 command to enabling including the script element of the skin in-line in the header or footer. Closed-Leaf check-in: dc88a533 user: drh tags: skin-script
23:34
Add the new "script" element to skins, accessible as /script.js. The idea is to put the hamburger menu javascript from the js-hamburger-menu branch in this script element, rather than inlining it in the footer. But I am not certain that is the best way to go so this change is parked on a branch for now. check-in: e5dbc612 user: drh tags: skin-script
22:21
Update the built-in SQLite to the first 3.25.0 release candidate. check-in: ed84acb6 user: drh tags: trunk
09:27
Removed the wrapping and moved the multicolumn styling applied to it down to the , since it is already a block level element, so we don't need a div wrapper on it. And then there's the real reason, which is that we want the multicolumn styling to work on the drop-down hamburger menu version as well. check-in: 0d391a1b user: wyoung tags: js-hamburger-menu
07:17
Converted JS hamburger button menu code to use standard JS only, no jQuery.    Temporarily lost the animation with this change: I'm checking this in separately to make the difference between this and the jQuery version clearer.    Not sure how portable it is yet; I wouldn't be surprised if it broke on old IE, since we're using xhr.onload instead of the horrid mess that is xhr.onreadystatechange. check-in: 113ba3d9 user: wyoung tags: js-hamburger-menu
2018-09-09
17:42
Merged in trunk improvements check-in: 96b1a9ca user: wyoung tags: js-hamburger-menu
17:41
Reverted [59c7ca0509]: drh says we can't use jQuery. Also, there was a syntax error that sent all hyperlinks to the honeypot in some conditions. check-in: 5a62b395 user: wyoung tags: js-hamburger-menu
2018-09-06
20:39
Update the built-in SQLite to the latest 3.25.0 alpha version for testing. check-in: 48171b66 user: drh tags: trunk
03:56
Converted src/href.js to jQuery as a demonstration: the code's nearly half the size, and it's clearer as a result. check-in: 59c7ca05 user: wyoung tags: js-hamburger-menu
03:06
Typo fix; patch by jungleboogie in forum post ID 775e4c0771. check-in: c8ef388b user: wyoung tags: trunk
2018-09-05
23:08
Ajaxy animated drop-down menu on clicking a new hamburger button in the default skin, as requested by drh on the forum: https://fossil-scm.org/forum/forumpost/40a18bd742    Initial version uses jQuery loaded from Google Hosted APIs for ease of development. check-in: d7c43c5a user: wyoung tags: js-hamburger-menu
15:16
Avoid column breaks inside a top-level bullet in the /sitemap. check-in: dc5e06ff user: drh tags: trunk
2018-09-03
16:12
Do away with compiler warning about uninitialized variable. check-in: af39da6d user: andybradford tags: trunk
07:40
Calling db_end_transaction() from the early-exit code paths of setup_skin_admin() to avoid "Transaction started at ./src/skins.c:466 never commits" complaints with some types of Admin -> Skins edits. check-in: 1c0b78b4 user: wyoung tags: trunk
00:24
The -quiet flag passed by default to tester.tcl can now be overridden by passing TESTFLAGS to make. Before, there was no way to set -verbose this way because "-quiet -verbose" means the same thing as "-quiet". check-in: 401a4c3d user: wyoung tags: trunk
2018-09-02
10:07
In the file browser, limit the maximum number of columns to be the number of files, so that a single file is never split across two columns. check-in: e585c3e6 user: drh tags: trunk
2018-09-01
14:52
Add 1em of left padding to multi-column unordered lists. This extra padding is necessary to get Chrome and Edge to display the bullets on second and subsequent columns. check-in: c429bb79 user: drh tags: trunk
14:19
Make the sitemap show in multiple columns on wide-screen browsers. check-in: 894cff0a user: drh tags: trunk
2018-08-31
22:41
Remove the n=200 query parameter from the timeline link on the /sitemap. check-in: f1e6cc13 user: drh tags: trunk
22:03
Login and subscription forms work better on mobile. check-in: 27769be9 user: drh tags: trunk
21:07
Render captchas in a smaller font that works better on mobile. check-in: 75c89def user: drh tags: trunk
20:24
Fix an unterminated transaction in the /admin_th1 page. check-in: 447d2732 user: drh tags: trunk
13:05
Improvements to the skin editor. check-in: bd2bf81c user: drh tags: trunk
11:59
Fix the "Public Pages" setting so that the initial part of the path that identifies a particular repository is ignored. check-in: d6cd1477 user: drh tags: trunk
11:32
Omit the Forum Search at the top of the /forum page if search is disabled. check-in: d4281bbc user: drh tags: trunk
11:05
Fix hyperlinks for extra pages on the /sitemap so that they correctly resolve to the root of the repository. check-in: 96fbcd13 user: drh tags: trunk
10:57
Fix to the configuration page for the License link in /sitemap. check-in: ace123b7 user: drh tags: trunk
10:47
Enhancements to the /sitemap page. New configuration options to add optional entries to the /sitemap page. check-in: 6898b3e7 user: drh tags: trunk
2018-08-30
21:20
Merge the email.c-to-alerts.c refactor. check-in: fc5c7d26 user: drh tags: trunk
21:19
Change the name of the "email.c" source file into "alerts.c". Make corresponding changes to various interfaces. Closed-Leaf check-in: cfbbc537 user: drh tags: refactor-alerts
16:13
Silence warning about unused variable check-in: 2f72c1fb user: andygoth tags: trunk
16:05
Add the ability to delete users to the /setup_uedit webpage. check-in: 1e5cdd35 user: drh tags: trunk
14:43
Attempt to make the /subscribe and /alerts forms less confusing. check-in: 6d04bab4 user: drh tags: trunk
14:03
Update the built-in SQLite to the latest 3.25.0 alpha version, for testing. check-in: 57e80ad2 user: drh tags: trunk
2018-08-29
12:57
Improvements to the capability listing page: /setup_ucap_list check-in: 8689cf8b user: drh tags: trunk
11:06
Disallow inline javascript unless protected by a nonce. check-in: ff747b51 user: drh tags: trunk
11:04
Try to start a new write transaction before updating the VCACHE table. This will hopefully prevent occasional "database is locked" errors when browsing the documentation. check-in: 03979823 user: drh tags: trunk
2018-08-27
15:00
Correct markdown reference documentation on optional outermost | characters check-in: 08e4371b user: andygoth tags: trunk
2018-08-26
02:20
Update JSON code to account for new capabilities. Also, the 'setup' and 'admin' capabilities should imply 'debug'. check-in: 3f12d406 user: mistachkin tags: trunk
2018-08-25
17:50
Merge enhancements from trunk. check-in: 17b9ecbe user: drh tags: csp-nonce
16:06
Added new CSS class forumPosts to the containing the list of posts on the /forum page so that skins can target elements of this list differently than others. One immediate use for this is styling read threads differently via a:visited styling. Currently, only one of the stock skins ships with an unconditional a:visited change, so that all links show in the same color regardless of their state. That's fine in most areas of the UI, but in the forum, a skin developer may want something special, so we need a way to mark them differently. This was already using the broadly-used "fileage" style, but we don't want changes to a:visited and such to affect all other users of fileage, so we need a unique style to this page. check-in: 77782490 user: wyoung tags: trunk
2018-08-24
08:29
Merge trunk. Undo unintended changes in previous commit check-in: 5583448c user: jan.nijtmans tags: openssl-1.1
08:25
Add configurations "enable-capieng" (use Windows Certificate Store) and "no-weak-ssl-ciphers" (disable RC4 support) check-in: b5a11142 user: jan.nijtmans tags: openssl-1.1
2018-08-23
16:02
Do not try to run backoffice if not connected to a valid repository. check-in: 3f5b2549 user: drh tags: trunk
15:14
Merge trunk. Update to Beta 7 of OpenSSL 1.1.1 (pre release 9, with TLS 1.3 support !!!) check-in: cbdbc0a0 user: jan.nijtmans tags: openssl-1.1
15:07
Add the meta-viewport header to the repository list page. check-in: bb7c2d91 user: drh tags: trunk
02:57
Put all javascript inline using a nonce. Disallow 'unsafe-inline' CSP for javascript. check-in: 89c40851 user: drh tags: csp-nonce
2018-08-22
19:43
Fix a unfinalized query in the /admin_log page. check-in: 6022ad49 user: drh tags: trunk
2018-08-21
01:33
Dynamic number of columns on the /help page, based on screen width check-in: 1d495e89 user: drh tags: trunk
2018-08-20
23:36
Add 10% more horizontal space in columns of the file browser /dir page. check-in: 0acb670e user: drh tags: trunk
19:30
For timeline graphs on narrow screens, set the rail pitch to its minimum value to conserve horizontal space. check-in: e63da90d user: drh tags: trunk
19:15
When displaying a timeline on a narrow screen, move the date to the third column to make the first column narrower. check-in: 8fc7c1b1 user: drh tags: trunk
18:29
Fix harmless compiler warnings. check-in: 02bd5941 user: drh tags: trunk
18:05
Make all webpages more mobile-friendly. There are still many tweaks possible, but it seems to basically work now. check-in: 9131af26 user: drh tags: trunk
18:04
Enable responsive design by default on all skins. Closed-Leaf check-in: 466744aa user: drh tags: mobile
17:51
Add automatic columnation of the capabilities in the /setup_uedit screen. check-in: 4f4956f8 user: drh tags: mobile
17:31
On the flat /dir webpage, automatically adjust the number of columns based on the screen width. check-in: 50698a3c user: drh tags: mobile
2018-08-17
15:38
Fix the /setup_smtp page so that it edits the routing table sensibly. check-in: 5416287d user: drh tags: trunk
14:24
Add the /emailoutq page, accessible only by the administrator. check-in: ca732777 user: drh tags: trunk
13:04
Break out the user configuration pages into a separate "setupuser.c" source file. check-in: a49ed35b user: drh tags: trunk
12:32
Improvements to privilege processing and the "Security Audit" page /secaudit0. check-in: 397d23c1 user: drh tags: trunk
01:27
Allow + signs in email addresses. Added a comment to link to a source giving the true limit on legal characters in email addresses, which are currently far less restrictive than our newly-expanded limits. check-in: 1bfd7903 user: wyoung tags: trunk
2018-08-16
20:48
Enhance the backoffice to automatically purge stale entries from the emailblob table, if that table exists. check-in: 4c7edd4c user: drh tags: trunk
19:51
Do not put "Return-Path:" headers in notification emails to be sent. That is a violation of standards as only the receiving SMTP server should add the Return-Path header. Instead, include a custom X-Fossil-From: header that downstream software can use (if desired) to set the envelope header of the message. check-in: 731836b8 user: drh tags: trunk
18:56
For email notifications abound events from a single user (such as individual forum post notifications) make the From: address be a "noreply" hash based on the users human-readable name or handle. Always include a Return-Path: field in the header that is the email-self setting, to be used by MTUs that need to bounce the message. check-in: 475c9d11 user: drh tags: trunk
16:45
Do not show posts that are awaiting moderation to users without moderator privilege unless they are the same user that generated the post in the first place. check-in: 16c42a08 user: drh tags: trunk
16:26
Update the built-in SQLite to the latest trunk version which includes the fix for EXPLAIN QUERY PLAN for the query that runs the /forum page. check-in: f8994f89 user: drh tags: trunk
16:13
Adjust the /forum page so that it for users without forum moderator privilege, it pretends that unmoderated posts do not exist, and for user with moderator privilege it paints an "Awaiting Moderator Approval" message on posts that need moderation. check-in: ef7f85ee user: drh tags: trunk
12:31
Fix the /forum page so that it links to the most recent post. check-in: b0ae37c0 user: drh tags: trunk
07:21
Improved locality of a variable. No functional change. check-in: 09103fd2 user: wyoung tags: trunk
07:06
Posts are now hidden on the /forum page if they're marked as private (i.e. needing moderator attention) and they were posted by another user, except when the user is a moderator.    (Closed because a different method was implemented on trunk.) Closed-Leaf check-in: 779eaaae user: wyoung tags: hide-post-if-needmod
06:36
Replaced a declare-and-init line pair with a single define-with-value line. No functional change. check-in: 8f47c3f6 user: wyoung tags: trunk
02:03
Fix the hextoblob() function so that does not report out-of-memory if the size of the input string is zero bytes. This fixes the instances of "out-of-memory" reports when accessing the /alerts page without an argument. check-in: 5519c6b8 user: drh tags: trunk
01:46
Fixes to the /webmail screen check-in: a24de3f9 user: drh tags: trunk
01:43
Add comments to the /register page implementation. No logic changes. check-in: a4419c6c user: drh tags: trunk
2018-08-15
21:28
Do not issue a warning about duplicate branch names when doing a --private check-in. check-in: d7e45aae user: drh tags: trunk
20:50
Improved title on on the /forum page. check-in: dbd96b2c user: drh tags: trunk
20:41
On the main /forum screen, provide the new n= and x= query parameters to enable access to older threads. check-in: aff20904 user: drh tags: trunk
20:17
On the "Recent Threads" page (/forum) show the number of messages and the duration of each thread. check-in: a50dfe6f user: drh tags: trunk
18:14
Improvements to self-register (the /register page) so that it works correctly for users how are already subscribers and enter the subscriber email. check-in: 4c43f2cd user: drh tags: trunk
15:53
Remove an db_begin_transaction() that had no matching db_end_transaction(). check-in: b2fca3dd user: drh tags: trunk
12:09
Change the default markup language for Forum to Markdown. check-in: 5f3cb278 user: drh tags: trunk
11:05
Update to openssl-1.0.2p check-in: 38638cfc user: jan.nijtmans tags: trunk
2018-08-14
13:05
Don't use "file nativename" in makemake.tcl, because it gives a different win/Makefile.msc when run on UNIX check-in: af80be5c user: jan.nijtmans tags: trunk
05:59
Changed all of the "sendmail -t" commands to "sendmail -ti" to make it ignore lines containing only a dot; we use EOF to signal "end of message," so we don't need the second signal. This is separate from the smtp.c fix in [51740ce45f]: that's only used when Fossil speaks directly to an SMTP server, where a leading dot is treated somewhat differently than the lone dot rule for sendmail(1)'s stdin.    This problem with leading dots was diagnosed by gumblex, /forumpost/4290f75ba1. check-in: 8c0ec30b user: wyoung tags: trunk
03:55
The blob-to-SMTP encoding logic was not strictly following RFC 5321 in that it was only dealing with the lone dot on the line case, doubling it to prevent the SMTP server from interpreting that as end-of-message. It missed the case where, if anything follows the dot, SMTP drops the leading dot, so you must also double the leading dot in that case. Basically, you always double a leading dot, regardless of line length.    This only affects Fossil's direct-to-SMTP email sending case, not those that send via a piped command or via DB. That is dealt with later in [8c0ec30bc3]. check-in: 51740ce4 user: wyoung tags: trunk
2018-08-12
21:35
Add /forum link to sitemap if user has RdForum capability check-in: 5ad7222f user: wyoung tags: trunk
10:42
Merge the fix to the login-by-email-address patch. check-in: 9b4e157b user: drh tags: trunk
03:38
Update wording to match documentation. Closed-Leaf check-in: cbfbfa8c user: mistachkin tags: updNewCaps
2018-08-11
23:51
Coding style tweak. Closed-Leaf check-in: 52b9caa5 user: mistachkin tags: login-with-email
23:47
Update JSON code to account for new capabilities. Also, the 'setup' and 'admin' capabilities should imply 'debug'. check-in: 7ce44fab user: mistachkin tags: updNewCaps
19:28
Zeroed a pointer in its declaration to squish a warning from GCC 4.8.4 on Ubuntu 14.04 about use of a potentially uninitted pointer. I don't think it's actually possible for the current code to use the pointer in the window between its declaration and first use, but I think we can afford the extra machine instruction this will cost us. (I assume newer GCCs are smart enough to analyze this situation correctly, which is why the warning hasn't been squished earlier.) check-in: 892781cb user: wyoung tags: trunk
16:59
Fix to checkin [8c91be8b], which was intended to allow the user to log in with the email found in the contact info field of the user table. That checkin is fine as far as it goes, but it only works if the caller doesn't subsequently try to use the passed user name for anything else, since it isn't actually a user name. This checkin causes the low-level login checking function to re-point the user name pointer at the actual login name discovered while scanning for matching email addresses. check-in: 33522ff4 user: wyoung tags: login-with-email
2018-08-10
23:28
Try to put the human name of the person who posted on the From: line of email notifications for new forum posts. check-in: ad419331 user: drh tags: trunk
20:30
Be sure to send forum event notifications in chronological order. check-in: b4602502 user: drh tags: trunk
17:08
Also remember the name the user for webmail. check-in: 800cd27d user: drh tags: trunk
16:59
Fix the webmail screen so that it remembers the folder that is being viewed. check-in: e0377d04 user: drh tags: trunk
16:51
Fix the /forum webpage so that it works even if the forumpost table does not exist in the repository. check-in: d73c5fd2 user: drh tags: trunk
16:44
Allow login using either the username or the first email address found in the USER.INFO column. Note that it might be useful to create an index on user(find_emailaddr(info)) to make this efficient in the case where there are many rows in the user table. check-in: 8c91be8b user: drh tags: trunk
16:16
Add the find_emailaddr() SQL function. check-in: 8a20d41f user: drh tags: trunk
2018-08-09
21:40
Remove an unused function from the backoffice.c. This problem only comes up on Windows as the function call was contained within #ifdef _WIN32. check-in: 2d732f40 user: drh tags: trunk
16:00
Fix an unfinalized prepared statement in the "fossil bisect ui" command. check-in: 148d4b66 user: drh tags: trunk
15:39
Improvements to formatting in generated emails to make them appear less like spam. Suggestions from "gahr" on the forum. check-in: 27404ad0 user: drh tags: trunk
14:15
Take care that a bug in the email alert sender results in missed alerts rather than an endless cascade of duplicate alerts. check-in: 164c3d1a user: drh tags: trunk
2018-08-08
23:59
Go ahead and permanently remove the backoffice timeout mechanism, as it seems clear we will not have a use for it moving forward. check-in: 4db38487 user: drh tags: trunk
20:56
Disable backoffice timeouts. This is a temporary measure to avoid a horrible bug in which a timeout causes the email notification sending process to exit before recording the fact that notifications have already been sent, and thus causing the same notifications to be sent again on the next backoffice cycle, and so forth over and over and over. check-in: 628d63c4 user: drh tags: trunk
20:01
Enhance the /register page so that it also does email subscriptions if that is enabled for self-registered users. check-in: 2e308280 user: drh tags: trunk
18:17
Fix the backoffice processes on unix so that they close file descriptors 0, 1, and 2 and reopen them on /dev/null, so as not to interfere with parent processes in any way. Restore the default of backoffice-nodelay back to off. Remove the /test-backoffice-lease webpage, which did not work correctly. check-in: c09b2512 user: drh tags: trunk
18:15
Remove the /test-backoffice-lease webpage, since it doesn't really work correctly. Use only the "fossil test-backoffice-lease" command moving forward. We can wrap that command in a Wapp script if necessary. Closed-Leaf check-in: b6aadace user: drh tags: backoffice-full-close
18:13
Set the default backoffice-nodelay back to off. check-in: 353a4e12 user: drh tags: backoffice-full-close
18:10
A simpler method of ensuring that backoffice does not cling to the standard input and output. check-in: 8c52c674 user: drh tags: backoffice-full-close
17:57
In the backoffice process, close the 0, 1, and 2 file descriptiors and reopen them as /dev/null, on unix. check-in: 6865fb72 user: drh tags: backoffice-full-close
16:20
If the "fds" query parameter is provided, then the /test-backoffice-lease webpage shows the open file descriptors. check-in: 918e1ddd user: drh tags: trunk
14:40
Turn backoffice-nodelay on by default. check-in: af599d6a user: drh tags: trunk
14:23
Add the /test-backoffice-lease web page. check-in: 4a544e5d user: drh tags: trunk
14:08
Make sure the backoffice has all file descriptors closed before it starts. check-in: 15f85cfd user: drh tags: trunk
13:47
Add table sorting to the subscriber list. check-in: 988cf44d user: drh tags: trunk
11:35
Add initial documentation about email alerts. Remove obsolete forum features from the "fossil config" command. check-in: 62411f37 user: drh tags: trunk
09:21
Update internal Unicode character tables, used in regular expression handling, from version 10.0 to 11.0. check-in: 1aff43a7 user: jan.nijtmans tags: trunk
02:21
Fix the build on unix. check-in: 88240d4d user: drh tags: trunk
02:15
More enhancements to backoffice diagnostics. check-in: 864a6f39 user: mistachkin tags: trunk
00:03
Fix some compiler warnings. check-in: 250fc00d user: mistachkin tags: trunk
00:01
Add the test-backoffice-lease command for testing the backoffice. check-in: f26ef806 user: drh tags: trunk
2018-08-07
23:48
Make the backoffice module tracing behave more consistently on Win32. check-in: 0fe9da81 user: mistachkin tags: trunk
23:22
Merge changes from the previous two check-ins. check-in: 30068260 user: mistachkin tags: trunk
23:16
Change backoffice-nodelay to default off. check-in: 12c487c4 user: drh tags: trunk
23:08
Improve Win32 error handling in the backoffice module and fix a compiler warning. check-in: 3c084879 user: mistachkin tags: trunk
23:03
Make it possible to debug child processes on Windows. check-in: e285341f user: mistachkin tags: trunk
23:01
Fix harmless compiler warning. check-in: 7014c2dd user: mistachkin tags: trunk
21:45
In the backoffice module, use GETPID macro consistently, fix compiler warning with MinGW, and add an assert(). check-in: af87fa5b user: mistachkin tags: trunk
21:44
Fix harmless compiler warning. check-in: 014bb2d7 user: mistachkin tags: trunk
21:43
Fix error when compiling with JSON support enabled (TODO: review semantics to preserve JSON error handling). check-in: f430f623 user: mistachkin tags: trunk
21:21
Report the time of the last backoffice run in the /stat page for administrators. check-in: ae6e8d97 user: drh tags: trunk
20:58
Improved windows code for the backoffice. Properly check to see if processes still exist. Provide a timeout feature. check-in: 43c29877 user: drh tags: trunk
20:11
Use the Windows _wspawnv() interface with the _P_NOWAIT option to start a separate backoffice process whenever necessary. Add the backoffice-logfile setting for monitoring backoffice operation. check-in: 2583cae1 user: drh tags: trunk
18:53
Allow manifest artifacts to omit the C and U cards, because otherwise there are some historical manifest artifacts in Fossil itself that will not parse, and there may be similar artifacts in other repositories. check-in: b3ccc4bf user: drh tags: trunk
18:30
Improvements to the way backoffice is launched, especially on unix where it now runs in a separate process using fork(). Also fix some minor bugs in other parts of the system that were found while testing backoffice. check-in: 4180dc6b user: drh tags: trunk
18:28
Improvements to comments. No code changes. Closed-Leaf check-in: 1b54dd79 user: drh tags: fork-backoffice
17:48
Fix the separate-process backoffice so that it works smoothly on linux. Still work to be done on Windows. check-in: af7d67c6 user: drh tags: fork-backoffice
15:50
Use the fork() system call (when available) to start backoffice, in an attempt to avoid unseemly delays in upstream. check-in: a4b59c32 user: drh tags: fork-backoffice
15:12
A new implementation for "Forum" in which each forum post is an artifact. This merge includes lots of enhancements to email notification, backoffice, configuration, and other subsystems, all in support of the new forum artifacts. The forum feature is not complete nor bug-free but at this point it seems good enough to continue development on trunk. check-in: 99fcc43f user: drh tags: trunk